Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] [Backport 2.x][MDS] Observability Datasource Plugin migration with MDS support for Data Connection Table #7384

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 704f2fa from #7371.

…S support for Data Connection Table (#7371)

* [MDS] Observability Datasource Plugin migration with MDS support (#7143)

* Observability Datasource Plugin migration with MDS support

Signed-off-by: Ryan Liang <[email protected]>

* Switch to use doc services for doc links of configuration of s3 datasource

Signed-off-by: Ryan Liang <[email protected]>

* Add tests for home panel

Signed-off-by: Ryan Liang <[email protected]>

* Fix the snapshot for mds

Signed-off-by: Ryan Liang <[email protected]>

* Add tests for data source creation panel

Signed-off-by: Ryan Liang <[email protected]>

* Add tests for dq data connection table

Signed-off-by: Ryan Liang <[email protected]>

* Add tests for dq configuration

Signed-off-by: Ryan Liang <[email protected]>

* Add readonly for s3glue doc link

Signed-off-by: Ryan Liang <[email protected]>

* Add tests for s3 prometheus creation and review

Signed-off-by: Ryan Liang <[email protected]>

* Fix mount feature flag behavior and tests

Signed-off-by: Ryan Liang <[email protected]>

* Shorten file names

Signed-off-by: Ryan Liang <[email protected]>

* Shorten file names again

Signed-off-by: Ryan Liang <[email protected]>

* Experiment 1

Signed-off-by: Ryan Liang <[email protected]>

* Fix the visbuilder failure 1

Signed-off-by: Ryan Liang <[email protected]>

* Fix the setter of datasource setup in vis_type_timeseries

Signed-off-by: Ryan Liang <[email protected]>

* Synced branch

Signed-off-by: Ryan Liang <[email protected]>

* Fix the readonly in doc link and add change log

Signed-off-by: Ryan Liang <[email protected]>

* Fix the create opensearch datasource's cancel button redirection

Signed-off-by: Ryan Liang <[email protected]>

* Add more test cases for breadscrumb changes and mount behavior based on the plugin registration

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>

* [MDS] Fix the dsm plugin setup when mds feature flag is disabled (#7163)

* Fix the dsm plugin setup when mds feature flag is disabled

Signed-off-by: Ryan Liang <[email protected]>

* Changeset file for PR #7163 created/updated

---------

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Changeset file for PR #7371 created/updated

* Fix snapshots

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 704f2fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 71.24183% with 88 lines in your changes missing coverage. Please review.

Project coverage is 68.14%. Comparing base (d59e3ea) to head (9eb1896).

Files Patch % Lines
...figuration/configure_direct_query_data_sources.tsx 53.94% 30 Missing and 5 partials ⚠️
...ion/manage_direct_query_data_connections_table.tsx 69.81% 12 Missing and 4 partials ⚠️
...guration/direct_query_data_source_auth_details.tsx 61.90% 7 Missing and 1 partial ⚠️
...tion/amazon_s3/configure_amazon_s3_data_source.tsx 63.15% 6 Missing and 1 partial ⚠️
...nnection/direct_query_data_source_delete_modal.tsx 50.00% 3 Missing and 1 partial ⚠️
...irect_query_data_source_configuration/name_row.tsx 86.36% 2 Missing and 1 partial ⚠️
...on/prometheus/configure_prometheus_data_source.tsx 72.72% 3 Missing ⚠️
...ry_data_source_configuration/query_permissions.tsx 78.57% 1 Missing and 2 partials ⚠️
...uration/amazon_s3/review_amazon_s3_data_source.tsx 66.66% 0 Missing and 2 partials ⚠️
...ation/prometheus/review_prometheus_data_source.tsx 66.66% 0 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             2.16    #7384      +/-   ##
==========================================
+ Coverage   68.13%   68.14%   +0.01%     
==========================================
  Files        3471     3488      +17     
  Lines       68759    69058     +299     
  Branches    11206    11247      +41     
==========================================
+ Hits        46849    47062     +213     
- Misses      19167    19234      +67     
- Partials     2743     2762      +19     
Flag Coverage Δ
Linux_1 33.27% <33.33%> (+<0.01%) ⬆️
Linux_2 55.58% <ø> (ø)
Linux_3 43.38% <71.61%> (+0.23%) ⬆️
Linux_4 34.86% <66.66%> (+0.01%) ⬆️
Windows_1 33.29% <33.33%> (+<0.01%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 43.38% <71.61%> (+0.22%) ⬆️
Windows_4 34.86% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit a9fd071 into 2.16 Jul 23, 2024
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants