Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Hide create data source routes when data_source.manageableBy is none #7378

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Backport 2.x] Hide create data source routes when data_source.manageableBy is none #7378

merged 1 commit into from
Jul 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2c6e78e from #7298.

@github-actions @opensearch-changeset-bot
Hide create data source routes when data_source.manageableBy is none (#…
5a569aa 
…7298)

* Hide create data source routes when feature flag is enabled

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

* Add flint related link

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

* Changeset file for PR #7298 created/updated

---------

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2c6e78e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added multiple datasource multiple datasource project autocut Skip the changelog verification check on backports v2.16.0 labels Jul 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (3fb7b8c) to head (5a569aa).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...public/management_app/mount_management_section.tsx 25.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #7378      +/-   ##
==========================================
- Coverage   67.82%   67.82%   -0.01%     
==========================================
  Files        3519     3519              
  Lines       69738    69741       +3     
  Branches    11365    11367       +2     
==========================================
- Hits        47303    47301       -2     
- Misses      19650    19651       +1     
- Partials     2785     2789       +4
Flag Coverage Δ
Linux_1 33.17% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 43.29% <25.00%> (-0.01%) ⬇️
Linux_4 34.97% <ø> (ø)
Windows_1 33.19% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 43.30% <25.00%> (-0.01%) ⬇️
Windows_4 34.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu merged commit 805d409 into 2.x Jul 23, 2024
66 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions
Hide create data source routes when data_source.manageableBy is none (#…
67f4e82 
…7298) (#7378)

(cherry picked from commit 805d409)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Merged
ruanyl pushed a commit that referenced this pull request Jul 23, 2024
@opensearch-trigger-bot @github-actions
Hide create data source routes when data_source.manageableBy is none (#…
a6a38aa 
…7298) (#7378) (#7389)

(cherry picked from commit 805d409)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyuanqi zhyuanqi zhyuanqi approved these changes

@zhongnansu zhongnansu zhongnansu approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports backport 2.16 failed changeset multiple datasource multiple datasource project v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongnansu @zhyuanqi @RyanL1997