[Workspace] Unassign data source before deleteByWorkspace

[raintygao]

Description

In current implementation, we call deleteByWorkspace to delete related saved objects when deleting a workspace. This will cause selected data source deleted when it is only assigned to this workspace. So we will unassign this data source before calling deleteByWorkspace.

Testing the changes

1. Use find API to find any data sources and what workspaces they belong to. http://localhost:6601/w/${OSD_ID}/api/saved_objects/_find?fields=id&fields=title&fields=workspaces&per_page=10000&type=data-source&workspaces=*
2. Enter workspace list page to delete some workspace.
3. Use find API then you could see that the data source is unassigned and still existed.

Changelog

• fix: Unassign data source before deleteByWorkspace

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (d2e7b9d) to head (2fbb5c4).
Report is 320 commits behind head on main.

Files with missing lines	Patch %	Lines
src/plugins/workspace/server/workspace_client.ts	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7279      +/-   ##
==========================================
+ Coverage   67.30%   67.33%   +0.02%     
==========================================
  Files        3500     3500              
  Lines       69219    69225       +6     
  Branches    11275    11276       +1     
==========================================
+ Hits        46591    46613      +22     
+ Misses      19903    19885      -18     
- Partials     2725     2727       +2     

Flag	Coverage Δ
Linux_1	33.25% <83.33%> (+0.01%)	⬆️
Linux_2	55.30% <ø> (ø)
Linux_3	45.27% <ø> (+0.01%)	⬆️
Windows_1	33.30% <83.33%> (+0.04%)	⬆️
Windows_2	55.25% <ø> (ø)
Windows_3	45.27% <ø> (ø)
Windows_4	34.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hailong-am]

thanks for fixing this 👍

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7279-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d67d6ba1c82153c4a1ea7874ac05f142f41f4eac
# Push it to GitHub
git push --set-upstream origin backport/backport-7279-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7279-to-2.x.