-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datasource readonly feature flag and disable certain routes #7256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7256 +/- ##
==========================================
- Coverage 67.62% 67.33% -0.30%
==========================================
Files 3471 3500 +29
Lines 68613 69224 +611
Branches 11165 11278 +113
==========================================
+ Hits 46399 46610 +211
- Misses 19510 19889 +379
- Partials 2704 2725 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
1 similar comment
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
2265881
to
b16bc13
Compare
#7214 It seems we are doing the same thing on restrict user from creating data source. Could we merge the codes from both PRs? |
Thanks @SuZhou-Joe ! Will sync offline and see if this can be combined efforts |
Overall looks good although I have a question about accessing |
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
close this PR as will use feature flag from #7214 |
close this PR as will use feature flag from #7214 |
Hi Huy. Thanks for noticing that. Yes. It is the behavior set by flint team
|
Description
Add datasource readonly feature flag and disable certain routes
Screenshot
When datasource is enabled and readonly is false, customer should be able to create and configure opensearch.
Screen.Recording.2024-07-15.at.11.01.32.PM.mov
When datasource is enabled and readonly is true, customer should not be able to create and configure openSearch.
Screen.Recording.2024-07-15.at.10.59.09.PM.mov
When datasource is diabled and readonly is disable, datasource section should be hidden
When datasource is diabled and readonly is true , datasource section should still be hidden
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration