[Backport 2.x] [Workspace]Restrict saved objects finding when workspace enabled #7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Limit data source saved objects finding and access when workspace enabled Signed-off-by: Lin Wang <[email protected]> * Remove options.workspaces drop behavior in conflict client wrapper Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7125 created/updated * Update src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts Co-authored-by: SuZhou-Joe <[email protected]> Signed-off-by: Lin Wang <[email protected]> * Update src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: Lin Wang <[email protected]> * Remove formatFindParams Signed-off-by: Lin Wang <[email protected]> * Fix code format Signed-off-by: Lin Wang <[email protected]> * Fix ACLSearchParams and empty workspaces Signed-off-by: Lin Wang <[email protected]> * Refactor workspace client wrapper find Signed-off-by: Lin Wang <[email protected]> * Remove global saved objects validation logic Signed-off-by: Lin Wang <[email protected]> * Update uts and its Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7125 created/updated * Remove no need changes and refactor Signed-off-by: Lin Wang <[email protected]> * Fix global saved objects not found Signed-off-by: Lin Wang <[email protected]> * Change saved object get to assert Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> (cherry picked from commit 1cb5956) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7182 +/- ##
==========================================
- Coverage 67.60% 67.60% -0.01%
==========================================
Files 3449 3449
Lines 68072 68061 -11
Branches 11056 11053 -3
==========================================
- Hits 46022 46011 -11
+ Misses 19382 19381 -1
- Partials 2668 2669 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jul 8, 2024
ruanyl
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1cb5956 from #7125.