Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Support global workspace #7096

Closed

Conversation

yubonluo
Copy link
Contributor

Description

Support global workspace.

Issues Resolved

#7095

Screenshot

Testing the changes

Changelog

  • feat: [Workspace] Support global workspace.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (170ac61) to head (d03e4d5).
Report is 7 commits behind head on main.

Files Patch % Lines
src/plugins/workspace/server/workspace_client.ts 7.14% 13 Missing ⚠️
...d_objects_management/server/routes/scroll_count.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7096      +/-   ##
==========================================
- Coverage   67.45%   67.44%   -0.02%     
==========================================
  Files        3448     3448              
  Lines       67957    67959       +2     
  Branches    11055    11052       -3     
==========================================
- Hits        45843    45832      -11     
- Misses      19443    19456      +13     
  Partials     2671     2671              
Flag Coverage Δ
Linux_1 33.08% <13.33%> (-0.03%) ⬇️
Linux_2 55.05% <ø> (ø)
Linux_3 45.24% <ø> (-0.02%) ⬇️
Linux_4 34.83% <50.00%> (-0.01%) ⬇️
Windows_1 33.10% <13.33%> (-0.03%) ⬇️
Windows_2 55.00% <ø> (ø)
Windows_3 45.25% <ø> (ø)
Windows_4 34.83% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yubonluo yubonluo requested a review from LDrago27 as a code owner June 27, 2024 01:43
@yubonluo yubonluo closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants