[BUG] Allow Save in Top Nav Menu to capture filter and query #6636

ananzh · 2024-04-25T05:57:43Z

Description

Before this PR, can't save when filter or query change.
After this PR:

if the canvas is empty, can not save filter and query updates. This is expected due to empty canvas error The canvas is empty. Add some aggregations before saving
if the canvas is not empty, can save filter and query updates.

vb-save-top-nav.mov

for embedded vis builder in dashboard, when edit vb, update filter and query can also enable save button

embeddable.mov

Issues Resolved

#5645

Testing the changes

We will need to add some cypress tests. Here is the meta issue to track #6635

Changelog

fix: [BUG] Allow Save in Top Nav Menu to capture filter and query

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-04-25T05:58:14Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>

codecov · 2024-04-25T06:15:32Z

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 67.73%. Comparing base (d2d410b) to head (e17d6af).
Report is 33 commits behind head on main.

Files	Patch %	Lines
..._builder/public/application/components/top_nav.tsx	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #6636       +/-   ##
===========================================
+ Coverage   32.93%   67.73%   +34.79%     
===========================================
  Files        2260     3403     +1143     
  Lines       45769    66613    +20844     
  Branches     7200    10828     +3628     
===========================================
+ Hits        15075    45119    +30044     
+ Misses      29984    18854    -11130     
- Partials      710     2640     +1930

Flag	Coverage Δ
Linux_1	`33.05% <0.00%> (+0.11%)`	⬆️
Linux_2	`55.60% <ø> (?)`
Linux_3	`45.24% <ø> (?)`
Linux_4	`34.93% <ø> (?)`
Windows_1	`33.07% <0.00%> (?)`
Windows_2	`55.57% <ø> (?)`
Windows_3	`45.25% <ø> (?)`
Windows_4	`34.93% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-25T06:53:18Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

kavilla · 2024-04-26T23:36:15Z

src/plugins/vis_builder/public/application/components/top_nav.tsx

@@ -3,7 +3,8 @@
 * SPDX-License-Identifier: Apache-2.0
 */

-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useState, useRef } from 'react';
+import { isEqual } from 'lodash';


guilty of doing this too. but i think we wanted to. avoid using lodash right?

github-actions · 2024-04-29T06:57:13Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve #5645 Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 7aa7a74) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…6687) Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve #5645 (cherry picked from commit 7aa7a74) Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…rch-project#6636) Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>

ananzh requested review from kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners April 25, 2024 05:57

github-actions bot added the distinguished-contributor label Apr 25, 2024

github-actions bot added the failed changeset label Apr 25, 2024

ananzh force-pushed the fix-5645 branch from ad4083e to 65f75f7 Compare April 25, 2024 06:01

[BUG] Allow Save in Top Nav Menu to capture filter and query

e17d6af

Before this PR, can't save when filter or query change. After this PR, if the canvas is not empty, can save filter and query updates. Issue Resolve opensearch-project#5645 Signed-off-by: Anan Zhuang <[email protected]>

ananzh force-pushed the fix-5645 branch from 65f75f7 to e17d6af Compare April 25, 2024 06:02

ananzh mentioned this pull request Apr 25, 2024

[VisBuilder ] Fix filter and query bugs in the saved objects #6460

Merged

7 tasks

ananzh added vis builder v2.14.0 backport 2.x labels Apr 25, 2024

kavilla reviewed Apr 26, 2024

View reviewed changes

kavilla approved these changes Apr 26, 2024

View reviewed changes

ashwin-pc approved these changes Apr 29, 2024

View reviewed changes

ananzh merged commit 7aa7a74 into opensearch-project:main Apr 30, 2024
71 of 74 checks passed

opensearch-trigger-bot bot mentioned this pull request Apr 30, 2024

[Backport 2.x] [BUG] Allow Save in Top Nav Menu to capture filter and query #6687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Allow Save in Top Nav Menu to capture filter and query #6636

[BUG] Allow Save in Top Nav Menu to capture filter and query #6636

ananzh commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024

codecov bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024

kavilla Apr 26, 2024

github-actions bot commented Apr 29, 2024

[BUG] Allow Save in Top Nav Menu to capture filter and query #6636

[BUG] Allow Save in Top Nav Menu to capture filter and query #6636

Conversation

ananzh commented Apr 25, 2024 • edited Loading

Description

Issues Resolved

Testing the changes

Changelog

Check List

github-actions bot commented Apr 25, 2024

❌ Invalid Prefix For Manual Changeset Creation

codecov bot commented Apr 25, 2024 • edited Loading

Codecov Report

github-actions bot commented Apr 25, 2024

❌ Invalid Prefix For Manual Changeset Creation

kavilla Apr 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2024

❌ Invalid Prefix For Manual Changeset Creation

ananzh commented Apr 25, 2024 •

edited

Loading

codecov bot commented Apr 25, 2024 •

edited

Loading