-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS] Refactor DataSourceAggregatedView #6500
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6500.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
a38567e
to
eddd667
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6500 +/- ##
===========================================
+ Coverage 32.93% 55.72% +22.78%
===========================================
Files 2260 2283 +23
Lines 45769 42759 -3010
Branches 7200 7608 +408
===========================================
+ Hits 15075 23827 +8752
+ Misses 29984 17501 -12483
- Partials 710 1431 +721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6500.yml under folder changelogs/fragments to complete this PR. File still missing. |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
The active view allows passing activeDataSourceIds which can be empty: in maps plugin, when creating the first layer, activeDataSourceIds may be empty, but we should show the active view instead of list all view, also, in maps plugin, when removing the layer, activeDataSourceIds may be empty as well |
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6500-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd0ea35ae6967c7594d316e3ab3b08534c3b3264
# Push it to GitHub
git push --set-upstream origin backport/backport-6500-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* Refactor aggregated view Signed-off-by: Huy Nguyen <[email protected]> * Add empty state support Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit bd0ea35)
* Refactor aggregated view Signed-off-by: Huy Nguyen <[email protected]> * Add empty state support Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit bd0ea35) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Refactor aggregated view * Add empty state support --------- (cherry picked from commit bd0ea35) Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Based on discussion from UX, this PR will refactor the
DataSourceAggregatedView
.TODO:
Issues Resolved
N/A
Screenshot
Screen.Recording.2024-04-17.at.11.57.41.AM.mov
Screen.Recording.2024-04-17.at.11.59.44.AM.mov
Testing the changes
Used the developer example plugin to test 3 scenarios of
DataSourceAggregatedView
:activeDataSourceId
anddisplayAllCompatibleDataSources: false
: This will render the switch to show only the selected componentsdisplayAllCompatibleDataSources: false
: This will render the switch and show an empty statedisplayAllCompatibleDataSources: true
: TheactiveDataSourceIds
is ignored, all datasources are unchecked, and no switch will be rendered.NoDataSources
component is renderedChangelog
Check List
yarn test:jest
yarn test:jest_integration