[Backport 2.x] [MDS] TSVB Support #6491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add MDS support to TSVB Signed-off-by: Huy Nguyen <[email protected]> * Refactor datasource picker component Signed-off-by: Huy Nguyen <[email protected]> * Allow picker to persist state Signed-off-by: Huy Nguyen <[email protected]> * Refactored picker component params Signed-off-by: Huy Nguyen <[email protected]> * Add unit tests Signed-off-by: Huy Nguyen <[email protected]> * Add to CHANGELOG Signed-off-by: Huy Nguyen <[email protected]> * Refactor components to use hideLocalCluster Signed-off-by: Huy Nguyen <[email protected]> * Remove Picker wrapper Signed-off-by: Huy Nguyen <[email protected]> * Update selector component and rename field to index name Signed-off-by: Huy Nguyen <[email protected]> * Address comments Signed-off-by: Huy Nguyen <[email protected]> * Refactor to use different decideClient Signed-off-by: Huy Nguyen <[email protected]> * Add optional arg Signed-off-by: Huy Nguyen <[email protected]> * Remove hidelocalcluster as a setting Signed-off-by: Huy Nguyen <[email protected]> * Fixed case where local cluster is disabled but the datasource id could be local cluster Signed-off-by: Huy Nguyen <[email protected]> * Add test for create data source picker handler Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> (cherry picked from commit be0f9d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
BionIT
approved these changes
Apr 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6491 +/- ##
===========================================
+ Coverage 31.75% 51.81% +20.06%
===========================================
Files 2220 2533 +313
Lines 44686 49250 +4564
Branches 6951 7663 +712
===========================================
+ Hits 14190 25519 +11329
+ Misses 29839 22527 -7312
- Partials 657 1204 +547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yujin-emma
approved these changes
Apr 17, 2024
yujin-emma
approved these changes
Apr 17, 2024
zhongnansu
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport be0f9d5 from #6298.