-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace control characters in logs #6402
Conversation
c3566f8
to
38a42db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6402 +/- ##
==========================================
+ Coverage 55.58% 55.62% +0.03%
==========================================
Files 1199 1200 +1
Lines 24259 24265 +6
Branches 4087 4088 +1
==========================================
+ Hits 13485 13498 +13
+ Misses 10133 10124 -9
- Partials 641 643 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: Miki <[email protected]>
f321480
to
4a20b6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-6402-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c89d3047d46ca809b6540c0fab8db33c6e736c09
# Push it to GitHub
git push --set-upstream origin backport/backport-6402-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6402-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c89d3047d46ca809b6540c0fab8db33c6e736c09
# Push it to GitHub
git push --set-upstream origin backport/backport-6402-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
Signed-off-by: Miki <[email protected]> (cherry picked from commit c89d304) Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]> (cherry picked from commit c89d304) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Signed-off-by: Miki <[email protected]> (cherry picked from commit c89d304) Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]> (cherry picked from commit c89d304) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit c89d304) Signed-off-by: Miki <[email protected]>
Description
This change replaces certain control characters with their representation from the logs.
Check List
yarn test:jest
yarn test:jest_integration