-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multiple Datasource] Remove arrow down icon from data source selectable component #6257
Conversation
Signed-off-by: Lu Yu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6257 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 3353 3353
Lines 65083 65083
Branches 10483 10483
=======================================
+ Hits 43837 43839 +2
+ Misses 18695 18694 -1
+ Partials 2551 2550 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BionIT can you please add a changelog entry for visual enhancement to data source selection? |
Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: Lu Yu <[email protected]>
done! Thanks @AMoo-Miki ! One question, for improvement for unreleased change, do we need to add change log as well? |
Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: Lu Yu <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6257-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74e0df3b86e5d70b11a7c2eb03082b09e0f985c5
# Push it to GitHub
git push --set-upstream origin backport/backport-6257-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…ble component (opensearch-project#6257) * remove arrowdown icon from data source selector Signed-off-by: Lu Yu <[email protected]> * add change log Signed-off-by: Lu Yu <[email protected]> * update snapshot Signed-off-by: Lu Yu <[email protected]> --------- Signed-off-by: Lu Yu <[email protected]>
…ble component (#6257) (#6319) * remove arrowdown icon from data source selector * add change log * update snapshot --------- Signed-off-by: Lu Yu <[email protected]>
Description
This change is part of #6216 to remove arrowdown icon from data source selectable component
Issues Resolved
Screenshot
removeicon.mp4
Testing the changes
After removing the arrow down icon, the data source selectable component renders correctly
Check List
yarn test:jest
yarn test:jest_integration