-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[osd/std] Add fallback mechanism when recovery from false-positives in handling of long numerals fails #6253
Conversation
/* Check for 1-i and 1-ii | ||
* Finding "..."෴1111"..." inside a string value, the extra quotes throw a syntax error | ||
* and the position points to " that is assumed to be the begining of a value. | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is just a try...catch
around the previous logic.
…n handling of long numerals fails Signed-off-by: Miki <[email protected]>
dfbcdbf
to
cdef4b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6253 +/- ##
==========================================
- Coverage 67.34% 67.34% -0.01%
==========================================
Files 3352 3352
Lines 65080 65082 +2
Branches 10485 10486 +1
==========================================
Hits 43829 43829
- Misses 18699 18700 +1
- Partials 2552 2553 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…n handling of long numerals fails (#6253) Signed-off-by: Miki <[email protected]> (cherry picked from commit 312075c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…n handling of long numerals fails (#6253) Signed-off-by: Miki <[email protected]> (cherry picked from commit 312075c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…n handling of long numerals fails (#6253) (#6260) Signed-off-by: Miki <[email protected]> (cherry picked from commit 312075c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…n handling of long numerals fails (#6253) (#6259) Signed-off-by: Miki <[email protected]> (cherry picked from commit 312075c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Earlier, the idea was to show these errors to harden the logic. With 3+ scenarios handled, this change allows for anything else to fallback to native
JSON.parse()
when recovery from false-positives doesn't succeed.Check List
yarn test:jest
yarn test:jest_integration