-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Employ a patched version of hoek that addresses CVE-2020-36604 #6148
Conversation
Signed-off-by: Miki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6148 +/- ##
==========================================
- Coverage 67.20% 67.18% -0.02%
==========================================
Files 3328 3328
Lines 64461 64461
Branches 10376 10376
==========================================
- Hits 43318 43306 -12
- Misses 18610 18622 +12
Partials 2533 2533
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6148-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c4f49a2200bb4622aea3ff70bb7a8c96983af5d
# Push it to GitHub
git push --set-upstream origin backport/backport-6148-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…earch-project#6148) Signed-off-by: Miki <[email protected]> (cherry picked from commit 8c4f49a)
Manual backport #6206 |
#6206) Signed-off-by: Miki <[email protected]> (cherry picked from commit 8c4f49a) Co-authored-by: Miki <[email protected]>
Description
Employ a patched version of hoek that addresses CVE-2020-36604.
Note: the patched library has tests added for prototype poisoning.
Can safely be backported to all versions that use this specific version.
Check List
yarn test:jest
yarn test:jest_integration