[Backport 2.x] [Multiple DataSource] DataSource creation and edition page improvement to better support registered auth types #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…t to better support registered auth types (#6122) * [Token Exchange Unification] State update for createDataSource and editDataSource pages Signed-off-by: Xinrui Bai <[email protected]> * [Token Exchange Unification] rectify state for dataSource creation page and edit page Signed-off-by: Xinrui Bai <[email protected]> * [UT] Add more test cases for util functions Signed-off-by: Xinrui Bai <[email protected]> * [Token Exchange Unification] Update dataSource bottom banner control Signed-off-by: Xinrui Bai <[email protected]> * Update changefile.md Signed-off-by: Xinrui Bai <[email protected]> * Add comments Signed-off-by: Xinrui Bai <[email protected]> * Code review change, fix typo Signed-off-by: Xinrui Bai <[email protected]> * Resolve comments, update typo in test cases Signed-off-by: Xinrui Bai <[email protected]> --------- Signed-off-by: Xinrui Bai <[email protected]> (cherry picked from commit 31e8481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
multiple datasource
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
SuZhou-Joe and
ruanyl
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6145 +/- ##
=======================================
Coverage 67.11% 67.12%
=======================================
Files 3316 3316
Lines 64080 64093 +13
Branches 10241 10241
=======================================
+ Hits 43008 43021 +13
Misses 18581 18581
Partials 2491 2491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bandinib-amzn
approved these changes
Mar 14, 2024
BionIT
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 31e8481 from #6122.