-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handles auth methods from auth registry in DataSourceSavedObjectsClientWrapper #6062
Handles auth methods from auth registry in DataSourceSavedObjectsClientWrapper #6062
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6062 +/- ##
========================================
Coverage 67.12% 67.12%
========================================
Files 3321 3319 -2
Lines 64085 64192 +107
Branches 10280 10308 +28
========================================
+ Hits 43015 43090 +75
- Misses 18566 18592 +26
- Partials 2504 2510 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
41ab868
to
91bf192
Compare
src/plugins/data_source/server/saved_objects/data_source_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Thanks for the change.
|
No. This should be fine. On server side how we store in auth registry is little bit different than browser side. On server side, type basically tells with which method request needs to sign. Authentication method can be anything. But there are only two ways we can sign the request - either Basic Auth or AWS SigV4 auth. or don't sign request at all which is No Auth. When we on server side, when authentication method will be registered from plugin or any other component, it will be registered as follows:
|
Signed-off-by: Bandini Bhopi <[email protected]>
Signed-off-by: Bandini Bhopi <[email protected]>
Signed-off-by: Bandini Bhopi <[email protected]>
2c59b21
to
229da5b
Compare
src/plugins/data_source/server/saved_objects/data_source_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Bandini Bhopi <[email protected]>
229da5b
to
b3382a5
Compare
…ntWrapper (#6062) * Handles auth methods from auth registry while saving data source Signed-off-by: Bandini Bhopi <[email protected]> * Add more UT and remove repetitive code Signed-off-by: Bandini Bhopi <[email protected]> * Adds changelog Signed-off-by: Bandini Bhopi <[email protected]> * Refactor code Signed-off-by: Bandini Bhopi <[email protected]> --------- Signed-off-by: Bandini Bhopi <[email protected]> (cherry picked from commit 9f3a689) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…ntWrapper (#6062) * Handles auth methods from auth registry while saving data source Signed-off-by: Bandini Bhopi <[email protected]> * Add more UT and remove repetitive code Signed-off-by: Bandini Bhopi <[email protected]> * Adds changelog Signed-off-by: Bandini Bhopi <[email protected]> * Refactor code Signed-off-by: Bandini Bhopi <[email protected]> --------- Signed-off-by: Bandini Bhopi <[email protected]> (cherry picked from commit 9f3a689) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…ntWrapper (#6062) (#6096) * Handles auth methods from auth registry while saving data source Signed-off-by: Bandini Bhopi <[email protected]> * Add more UT and remove repetitive code Signed-off-by: Bandini Bhopi <[email protected]> * Adds changelog Signed-off-by: Bandini Bhopi <[email protected]> * Refactor code Signed-off-by: Bandini Bhopi <[email protected]> --------- Signed-off-by: Bandini Bhopi <[email protected]> (cherry picked from commit 9f3a689) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR handles auth methods from auth registry in DataSourceSavedObjectsClientWrapper.
Issues Resolved
Partially fixes #5692, #5838
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration