Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Following pr for #5949 #6012

Merged
merged 4 commits into from
Mar 4, 2024
Merged

[Workspace]Following pr for #5949 #6012

merged 4 commits into from
Mar 4, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Mar 4, 2024 •
edited
Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe
feat: temp save
f2691b1 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
fix: unit test
74ed1db 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe
feat: add some comment
1ba7c69 
Signed-off-by: SuZhou-Joe <[email protected]>
@SuZhou-Joe SuZhou-Joe added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.13.0 workspace labels Mar 4, 2024
@Hailong-am Hailong-am mentioned this pull request Mar 4, 2024
Merged
7 tasks
ruanyl
ruanyl approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick updates, LGTM

ashwin-pc
ashwin-pc approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for the CI to pass before merging, but this PR otherwise looks good

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.10%. Comparing base (4943f06) to head (bc55fd1).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6012   +/-   ##
=======================================
  Coverage   67.10%   67.10%           
=======================================
  Files        3315     3315           
  Lines       63904    63904           
  Branches    10220    10220           
=======================================
  Hits        42880    42880           
- Misses      18539    18540    +1     
+ Partials     2485     2484    -1
Flag Coverage Δ
Linux_1 31.64% <100.00%> (?)
Linux_2 55.07% <ø> (ø)
Linux_3 44.59% <ø> (+0.01%) ⬆️
Linux_4 35.17% <ø> (ø)
Windows_1 31.66% <100.00%> (ø)
Windows_2 55.04% <ø> (ø)
Windows_3 44.59% <ø> (-0.01%) ⬇️
Windows_4 35.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 9901bea into opensearch-project:main Mar 4, 2024
119 of 121 checks passed
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 4, 2024
@SuZhou-Joe @ashwin-pc
[Workspace]Following pr for opensearch-project#5949 (opensearch-proje…
6db774e 
…ct#6012)

* feat: temp save

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add some comment

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 4, 2024
@SuZhou-Joe @ashwin-pc
[Workspace]Following pr for opensearch-project#5949 (opensearch-proje…
409717d 
…ct#6012)

* feat: temp save

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add some comment

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
SuZhou-Joe added a commit to ruanyl/OpenSearch-Dashboards that referenced this pull request Mar 5, 2024
@SuZhou-Joe @ashwin-pc
[Workspace]Following pr for opensearch-project#5949 (opensearch-proje…
b14060a 
…ct#6012) (#276)

* feat: temp save



* fix: unit test



* feat: add some comment



---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
SuZhou-Joe added a commit to ruanyl/OpenSearch-Dashboards that referenced this pull request Mar 5, 2024
@SuZhou-Joe @ashwin-pc
[Workspace]Following pr for opensearch-project#5949 (opensearch-proje…
d165b88 
…ct#6012) (#277)

* feat: temp save



* fix: unit test



* feat: add some comment



---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
@ruanyl ruanyl removed the v2.13.0 label Mar 12, 2024
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Apr 10, 2024
@SuZhou-Joe @ashwin-pc
[Workspace]Following pr for opensearch-project#5949 (opensearch-proje…
78277fc 
…ct#6012)

* feat: temp save

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add some comment

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
@SuZhou-Joe SuZhou-Joe mentioned this pull request Apr 10, 2024
Merged
SuZhou-Joe added a commit that referenced this pull request Apr 11, 2024
@SuZhou-Joe @ashwin-pc
[Backport 2.x][Workspace]Optional workspaces params in repository (#5949
38742b1 
) (#6387)

* [Workspace]Optional workspaces params in repository (#5949)

* refact: move workspace specific logic to savedObjectWrapper

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: some error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix test error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless config in test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add CHANGELOG

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add more unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in repository.test.js

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in import_saved_objects.test.ts

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: revert test in repository.test.js

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add type

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bootstrap type error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code and add comment

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: integration test fail

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add missing code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: optimize code

Signed-off-by: SuZhou-Joe <[email protected]>

* Add permissions field to the mapping only if the permission control is enabled

Signed-off-by: gaobinlong <[email protected]>

* Fix test failure

Signed-off-by: gaobinlong <[email protected]>

* feat: modify unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bulk create error

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: bulk create error

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add new config in yml file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add new config in yml file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update yml file

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: fix unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: do not skip migration when doing integration test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: remove useless code

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: change flag variable

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add test cases

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
(cherry picked from commit c6b4c34)

* [Workspace]Following pr for #5949 (#6012)

* feat: temp save

Signed-off-by: SuZhou-Joe <[email protected]>

* fix: unit test

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add some comment

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

Assignees
No one assigned
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @ruanyl @ashwin-pc