[Bug][Discover] Allow saved sort from search embeddable to load in Dashboard #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shboard Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
ananzh
added
v2.13.0
backport 2.x
discover
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5934 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 3307 3307
Lines 63614 63614
Branches 10163 10163
=======================================
Hits 42627 42627
Misses 18518 18518
Partials 2469 2469
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Feb 23, 2024
manasvinibs
approved these changes
Feb 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
…shboard (#5934) Remove default sort to use saved search sort. Issue Resolve #5933 Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 790c076) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
to BionIT/OpenSearch-Dashboards
that referenced
this pull request
Feb 24, 2024
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>
I'm curious to know why it is nice not required to have test? just want to be sure we could maintain same quality bar |
discover-sort.mov |
|
@seraphjiang you are right, this is not a nice to have test, but a required one. @ananzh can you as a followup to this PR add a test for this scenario? My original hesitation was because I was worried that we would be adding testing here for testing sake. But that is an unnecessary worry. |
|
Thanks @ashwin-pc for clarification. |
This was referenced Feb 27, 2024
|
@ashwin-pc @seraphjiang Yes, we do have a meta issue to create more tests for discover #5713. |
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Feb 27, 2024
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>
abbyhu2000
added a commit
that referenced
this pull request
Feb 29, 2024
…shboard (#5934) (#5938) Remove default sort to use saved search sort. Issue Resolve #5933 Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 790c076) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Qingyang(Abby) Hu <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>
4 tasks
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>
SuZhou-Joe
pushed a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Apr 7, 2024
…shboard (opensearch-project#5934) Remove default sort to use saved search sort. Issue Resolve opensearch-project#5933 Signed-off-by: Anan Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove default sort to use saved search sort.
Issues Resolved
#5933
Screenshot
save.mov
Check List
yarn test:jestyarn test:jest_integration