Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add datasource picker to import saved object flyout when multiple data source is enabled #5807

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[Backport 2.x] Add datasource picker to import saved object flyout when multiple data source is enabled #5807

merged 1 commit into from
Feb 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8e93c54 from #5781.

@opensearch-trigger-bot opensearch-trigger-bot bot added multiple datasource multiple datasource project autocut Skip the changelog verification check on backports v2.12.0 labels Feb 5, 2024
@AMoo-Miki AMoo-Miki marked this pull request as draft February 5, 2024 22:27
@AMoo-Miki
Copy link
Collaborator

Pending a change from @yujin-emma

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0926ae6) 66.92% compared to head (026cf97) 66.96%.

Files Patch % Lines
...gement_section/objects_table/components/flyout.tsx 75.00% 3 Missing ⚠️
...c/components/cluster_selector/cluster_selector.tsx 60.00% 2 Missing ⚠️
...saved_objects_management/public/lib/import_file.ts 0.00% 2 Missing ⚠️
...cts_management/public/lib/resolve_import_errors.ts 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #5807      +/-   ##
==========================================
+ Coverage   66.92%   66.96%   +0.04%     
==========================================
  Files        2585     3299     +714     
  Lines       48654    63464   +14810     
  Branches     8701    10086    +1385     
==========================================
+ Hits        32560    42497    +9937     
- Misses      14049    18500    +4451     
- Partials     2045     2467     +422
Flag Coverage Δ
Linux_1 35.23% <0.00%> (?)
Linux_3 ?
Linux_4 ?
Windows_1 35.26% <0.00%> (?)
Windows_2 55.14% <ø> (ø)
Windows_3 43.94% <60.00%> (-0.01%) ⬇️
Windows_4 35.41% <60.71%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions @bandinib-amzn
Add datasource picker to import saved object flyout when multiple dat…
026cf97 
…a source is enabled (#5781)

* add datasource picker to saved object management page when multiple data source is enabled

Signed-off-by: Lu Yu <[email protected]>

* add changelog

Signed-off-by: Lu Yu <[email protected]>

* change name to cluster selector and move to higher level

Signed-off-by: Lu Yu <[email protected]>

---------

Signed-off-by: Lu Yu <[email protected]>
(cherry picked from commit 8e93c54)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@bandinib-amzn bandinib-amzn force-pushed the backport/backport-5781-to-2.x branch from f230a79 to 026cf97 Compare February 6, 2024 21:17
@bandinib-amzn bandinib-amzn marked this pull request as ready for review February 6, 2024 21:18
@BionIT
Copy link
Collaborator

BionIT commented Feb 6, 2024

Pending a change from @yujin-emma

Emma's 2.x backport PR #5820

@ZilongX ZilongX merged commit 8fae687 into 2.x Feb 6, 2024
66 of 67 checks passed
@github-actions github-actions bot deleted the backport/backport-5781-to-2.x branch February 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZilongX ZilongX ZilongX approved these changes

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports multiple datasource multiple datasource project v2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AMoo-Miki @BionIT @zengyan-amazon @ZilongX