Allow switch between legacy table of a placeholder and data grid #5739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a html placeholder for default table. Allow two switch types: 1) use advanced setting to disable legacy table 2) use toggle on discover page Signed-off-by: Anan Z <[email protected]>
Signed-off-by: Anan Z <[email protected]>
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
7 tasks
|
Old one is #5723 |
|
Update changes based on the feedbacks from #5716 add_feedback.mov |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5739 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 3295 3297 +2
Lines 63329 63346 +17
Branches 10084 10087 +3
=======================================
+ Hits 42451 42467 +16
- Misses 18429 18430 +1
Partials 2449 2449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anan Z <[email protected]>
|
Update based on request to use local storage and remove advanced settings to avoid any risk for customers local-storage.mov |
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Jan 29, 2024
According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]>
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Jan 31, 2024
According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]>
|
will raise one PR for restore legacy table |
ashwin-pc
added a commit
that referenced
this pull request
Feb 7, 2024
…5789) * basic table working Signed-off-by: abbyhu2000 <[email protected]> * basic styling Signed-off-by: abbyhu2000 <[email protected]> * fix header column style Signed-off-by: abbyhu2000 <[email protected]> * correctly display optional col header actions Signed-off-by: abbyhu2000 <[email protected]> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <[email protected]> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <[email protected]> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <[email protected]> * sorting Signed-off-by: abbyhu2000 <[email protected]> * Add toggling between legacy and new table According to #5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]> * get rid of the console log Signed-off-by: abbyhu2000 <[email protected]> * optimize cell filter logics Signed-off-by: abbyhu2000 <[email protected]> * add more refactoring Signed-off-by: abbyhu2000 <[email protected]> * remove an used line Signed-off-by: abbyhu2000 <[email protected]> * some more table cell optimization Signed-off-by: abbyhu2000 <[email protected]> * Initial UI fixes (#5758) Signed-off-by: Ashwin P Chandran <[email protected]> * Table optimization with lazy loading (#5760) Signed-off-by: abbyhu2000 <[email protected]> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <[email protected]> * [Discover] Fix more UI (#5764) Signed-off-by: Ashwin P Chandran <[email protected]> * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <[email protected]> * improved loader Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Change sort icon according to current sort conditions (#5772) Signed-off-by: abbyhu2000 <[email protected]> * fix breadcrumb navigation (#5773) Signed-off-by: abbyhu2000 <[email protected]> * Add pagination to discover embeddable (#5770) * Add pagination Signed-off-by: abbyhu2000 <[email protected]> * fix an errir Signed-off-by: abbyhu2000 <[email protected]> * small change Signed-off-by: abbyhu2000 <[email protected]> * fix errors Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Prevent wrapping of time series cells (#5779) Signed-off-by: Miki <[email protected]> * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) Signed-off-by: Miki <[email protected]> * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <[email protected]> * [Discover] Display filter buttons at top right of the cell (#5784) Signed-off-by: Miki <[email protected]> * [Discover] Vertically align the details toggle button (#5785) Signed-off-by: Miki <[email protected]> * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <[email protected]> * Fix overflow problem of detailed doc Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> * update feedback msg (#5787) Signed-off-by: Anan Z <[email protected]> * Resolve sort, default sort and short dot (#5771) Signed-off-by: Anan Z <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> * [Discover] Fixes pagination style (#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <[email protected]> * style-lint fix Signed-off-by: Ashwin P Chandran <[email protected]> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <[email protected]> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <[email protected]> * removed unnecessary div Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> * fix table column error Signed-off-by: abbyhu2000 <[email protected]> * Fix pagination edge case Signed-off-by: abbyhu2000 <[email protected]> * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <[email protected]> * change path to not include appstate Signed-off-by: abbyhu2000 <[email protected]> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * type fixes (#5795) Signed-off-by: Ashwin P Chandran <[email protected]> * Update toggle to button (#5808) Signed-off-by: Ashwin P Chandran <[email protected]> * Adds support for line count (#5814) Signed-off-by: Ashwin P Chandran <[email protected]> * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <[email protected]> * fix ciGroup7 Signed-off-by: Anan Z <[email protected]> * fix ciGroup6 Signed-off-by: Anan Z <[email protected]> --------- Signed-off-by: Anan <[email protected]> Signed-off-by: Anan Z <[email protected]> * add missing snapshot (#5818) Signed-off-by: Anan Z <[email protected]> * fix pluign ftr tests (#5821) Signed-off-by: Anan Z <[email protected]> * update snapshot (#5824) Signed-off-by: abbyhu2000 <[email protected]> * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * dashboard expect Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Solve cigroup 7 flakiness (#5826) * test hover Signed-off-by: abbyhu2000 <[email protected]> * comment out other ci to speed up Signed-off-by: abbyhu2000 <[email protected]> * uncomment Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <[email protected]> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <[email protected]> * removes sub module from branch Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Persist line height (#5836) Signed-off-by: Ashwin P Chandran <[email protected]> * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <[email protected]> * nit Signed-off-by: Ashwin P Chandran <[email protected]> * update changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
…5789) * basic table working Signed-off-by: abbyhu2000 <[email protected]> * basic styling Signed-off-by: abbyhu2000 <[email protected]> * fix header column style Signed-off-by: abbyhu2000 <[email protected]> * correctly display optional col header actions Signed-off-by: abbyhu2000 <[email protected]> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <[email protected]> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <[email protected]> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <[email protected]> * sorting Signed-off-by: abbyhu2000 <[email protected]> * Add toggling between legacy and new table According to #5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]> * get rid of the console log Signed-off-by: abbyhu2000 <[email protected]> * optimize cell filter logics Signed-off-by: abbyhu2000 <[email protected]> * add more refactoring Signed-off-by: abbyhu2000 <[email protected]> * remove an used line Signed-off-by: abbyhu2000 <[email protected]> * some more table cell optimization Signed-off-by: abbyhu2000 <[email protected]> * Initial UI fixes (#5758) Signed-off-by: Ashwin P Chandran <[email protected]> * Table optimization with lazy loading (#5760) Signed-off-by: abbyhu2000 <[email protected]> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <[email protected]> * [Discover] Fix more UI (#5764) Signed-off-by: Ashwin P Chandran <[email protected]> * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <[email protected]> * improved loader Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Change sort icon according to current sort conditions (#5772) Signed-off-by: abbyhu2000 <[email protected]> * fix breadcrumb navigation (#5773) Signed-off-by: abbyhu2000 <[email protected]> * Add pagination to discover embeddable (#5770) * Add pagination Signed-off-by: abbyhu2000 <[email protected]> * fix an errir Signed-off-by: abbyhu2000 <[email protected]> * small change Signed-off-by: abbyhu2000 <[email protected]> * fix errors Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Prevent wrapping of time series cells (#5779) Signed-off-by: Miki <[email protected]> * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) Signed-off-by: Miki <[email protected]> * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <[email protected]> * [Discover] Display filter buttons at top right of the cell (#5784) Signed-off-by: Miki <[email protected]> * [Discover] Vertically align the details toggle button (#5785) Signed-off-by: Miki <[email protected]> * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <[email protected]> * Fix overflow problem of detailed doc Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> * update feedback msg (#5787) Signed-off-by: Anan Z <[email protected]> * Resolve sort, default sort and short dot (#5771) Signed-off-by: Anan Z <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> * [Discover] Fixes pagination style (#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <[email protected]> * style-lint fix Signed-off-by: Ashwin P Chandran <[email protected]> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <[email protected]> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <[email protected]> * removed unnecessary div Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> * fix table column error Signed-off-by: abbyhu2000 <[email protected]> * Fix pagination edge case Signed-off-by: abbyhu2000 <[email protected]> * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <[email protected]> * change path to not include appstate Signed-off-by: abbyhu2000 <[email protected]> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * type fixes (#5795) Signed-off-by: Ashwin P Chandran <[email protected]> * Update toggle to button (#5808) Signed-off-by: Ashwin P Chandran <[email protected]> * Adds support for line count (#5814) Signed-off-by: Ashwin P Chandran <[email protected]> * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <[email protected]> * fix ciGroup7 Signed-off-by: Anan Z <[email protected]> * fix ciGroup6 Signed-off-by: Anan Z <[email protected]> --------- Signed-off-by: Anan <[email protected]> Signed-off-by: Anan Z <[email protected]> * add missing snapshot (#5818) Signed-off-by: Anan Z <[email protected]> * fix pluign ftr tests (#5821) Signed-off-by: Anan Z <[email protected]> * update snapshot (#5824) Signed-off-by: abbyhu2000 <[email protected]> * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * dashboard expect Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Solve cigroup 7 flakiness (#5826) * test hover Signed-off-by: abbyhu2000 <[email protected]> * comment out other ci to speed up Signed-off-by: abbyhu2000 <[email protected]> * uncomment Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <[email protected]> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <[email protected]> * removes sub module from branch Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Persist line height (#5836) Signed-off-by: Ashwin P Chandran <[email protected]> * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <[email protected]> * nit Signed-off-by: Ashwin P Chandran <[email protected]> * update changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]> (cherry picked from commit e13dbff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
to ashwin-pc/OpenSearch-Dashboards
that referenced
this pull request
Feb 7, 2024
…pensearch-project#5789) * basic table working Signed-off-by: abbyhu2000 <[email protected]> * basic styling Signed-off-by: abbyhu2000 <[email protected]> * fix header column style Signed-off-by: abbyhu2000 <[email protected]> * correctly display optional col header actions Signed-off-by: abbyhu2000 <[email protected]> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <[email protected]> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <[email protected]> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <[email protected]> * sorting Signed-off-by: abbyhu2000 <[email protected]> * Add toggling between legacy and new table According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]> * get rid of the console log Signed-off-by: abbyhu2000 <[email protected]> * optimize cell filter logics Signed-off-by: abbyhu2000 <[email protected]> * add more refactoring Signed-off-by: abbyhu2000 <[email protected]> * remove an used line Signed-off-by: abbyhu2000 <[email protected]> * some more table cell optimization Signed-off-by: abbyhu2000 <[email protected]> * Initial UI fixes (opensearch-project#5758) Signed-off-by: Ashwin P Chandran <[email protected]> * Table optimization with lazy loading (opensearch-project#5760) Signed-off-by: abbyhu2000 <[email protected]> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <[email protected]> * [Discover] Fix more UI (opensearch-project#5764) Signed-off-by: Ashwin P Chandran <[email protected]> * [Discover] Fixes table optimization (opensearch-project#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <[email protected]> * improved loader Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Change sort icon according to current sort conditions (opensearch-project#5772) Signed-off-by: abbyhu2000 <[email protected]> * fix breadcrumb navigation (opensearch-project#5773) Signed-off-by: abbyhu2000 <[email protected]> * Add pagination to discover embeddable (opensearch-project#5770) * Add pagination Signed-off-by: abbyhu2000 <[email protected]> * fix an errir Signed-off-by: abbyhu2000 <[email protected]> * small change Signed-off-by: abbyhu2000 <[email protected]> * fix errors Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Prevent wrapping of time series cells (opensearch-project#5779) Signed-off-by: Miki <[email protected]> * Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780) Signed-off-by: Miki <[email protected]> * Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <[email protected]> * [Discover] Display filter buttons at top right of the cell (opensearch-project#5784) Signed-off-by: Miki <[email protected]> * [Discover] Vertically align the details toggle button (opensearch-project#5785) Signed-off-by: Miki <[email protected]> * [Discover] Fix overflow of the expanded document (opensearch-project#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <[email protected]> * Fix overflow problem of detailed doc Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> * update feedback msg (opensearch-project#5787) Signed-off-by: Anan Z <[email protected]> * Resolve sort, default sort and short dot (opensearch-project#5771) Signed-off-by: Anan Z <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> * [Discover] Fixes pagination style (opensearch-project#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <[email protected]> * style-lint fix Signed-off-by: Ashwin P Chandran <[email protected]> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <[email protected]> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <[email protected]> * removed unnecessary div Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> * fix table column error Signed-off-by: abbyhu2000 <[email protected]> * Fix pagination edge case Signed-off-by: abbyhu2000 <[email protected]> * Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <[email protected]> * change path to not include appstate Signed-off-by: abbyhu2000 <[email protected]> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * type fixes (opensearch-project#5795) Signed-off-by: Ashwin P Chandran <[email protected]> * Update toggle to button (opensearch-project#5808) Signed-off-by: Ashwin P Chandran <[email protected]> * Adds support for line count (opensearch-project#5814) Signed-off-by: Ashwin P Chandran <[email protected]> * Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <[email protected]> * fix ciGroup7 Signed-off-by: Anan Z <[email protected]> * fix ciGroup6 Signed-off-by: Anan Z <[email protected]> --------- Signed-off-by: Anan <[email protected]> Signed-off-by: Anan Z <[email protected]> * add missing snapshot (opensearch-project#5818) Signed-off-by: Anan Z <[email protected]> * fix pluign ftr tests (opensearch-project#5821) Signed-off-by: Anan Z <[email protected]> * update snapshot (opensearch-project#5824) Signed-off-by: abbyhu2000 <[email protected]> * Fix functional 3 and 4 for discover legacy (opensearch-project#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * dashboard expect Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Solve cigroup 7 flakiness (opensearch-project#5826) * test hover Signed-off-by: abbyhu2000 <[email protected]> * comment out other ci to speed up Signed-off-by: abbyhu2000 <[email protected]> * uncomment Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Simplify feedback modal (opensearch-project#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <[email protected]> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <[email protected]> * removes sub module from branch Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Persist line height (opensearch-project#5836) Signed-off-by: Ashwin P Chandran <[email protected]> * Update table revert changelog (opensearch-project#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <[email protected]> * nit Signed-off-by: Ashwin P Chandran <[email protected]> * update changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]> (cherry picked from commit e13dbff)
ashwin-pc
added a commit
that referenced
this pull request
Feb 8, 2024
…5789) (#5840) * basic table working Signed-off-by: abbyhu2000 <[email protected]> * basic styling Signed-off-by: abbyhu2000 <[email protected]> * fix header column style Signed-off-by: abbyhu2000 <[email protected]> * correctly display optional col header actions Signed-off-by: abbyhu2000 <[email protected]> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <[email protected]> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <[email protected]> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <[email protected]> * sorting Signed-off-by: abbyhu2000 <[email protected]> * Add toggling between legacy and new table According to #5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]> * get rid of the console log Signed-off-by: abbyhu2000 <[email protected]> * optimize cell filter logics Signed-off-by: abbyhu2000 <[email protected]> * add more refactoring Signed-off-by: abbyhu2000 <[email protected]> * remove an used line Signed-off-by: abbyhu2000 <[email protected]> * some more table cell optimization Signed-off-by: abbyhu2000 <[email protected]> * Initial UI fixes (#5758) Signed-off-by: Ashwin P Chandran <[email protected]> * Table optimization with lazy loading (#5760) Signed-off-by: abbyhu2000 <[email protected]> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <[email protected]> * [Discover] Fix more UI (#5764) Signed-off-by: Ashwin P Chandran <[email protected]> * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <[email protected]> * improved loader Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Change sort icon according to current sort conditions (#5772) Signed-off-by: abbyhu2000 <[email protected]> * fix breadcrumb navigation (#5773) Signed-off-by: abbyhu2000 <[email protected]> * Add pagination to discover embeddable (#5770) * Add pagination Signed-off-by: abbyhu2000 <[email protected]> * fix an errir Signed-off-by: abbyhu2000 <[email protected]> * small change Signed-off-by: abbyhu2000 <[email protected]> * fix errors Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Prevent wrapping of time series cells (#5779) Signed-off-by: Miki <[email protected]> * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) Signed-off-by: Miki <[email protected]> * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <[email protected]> * [Discover] Display filter buttons at top right of the cell (#5784) Signed-off-by: Miki <[email protected]> * [Discover] Vertically align the details toggle button (#5785) Signed-off-by: Miki <[email protected]> * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <[email protected]> * Fix overflow problem of detailed doc Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> * update feedback msg (#5787) Signed-off-by: Anan Z <[email protected]> * Resolve sort, default sort and short dot (#5771) Signed-off-by: Anan Z <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> * [Discover] Fixes pagination style (#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <[email protected]> * style-lint fix Signed-off-by: Ashwin P Chandran <[email protected]> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <[email protected]> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <[email protected]> * removed unnecessary div Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> * fix table column error Signed-off-by: abbyhu2000 <[email protected]> * Fix pagination edge case Signed-off-by: abbyhu2000 <[email protected]> * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <[email protected]> * change path to not include appstate Signed-off-by: abbyhu2000 <[email protected]> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * type fixes (#5795) Signed-off-by: Ashwin P Chandran <[email protected]> * Update toggle to button (#5808) Signed-off-by: Ashwin P Chandran <[email protected]> * Adds support for line count (#5814) Signed-off-by: Ashwin P Chandran <[email protected]> * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <[email protected]> * fix ciGroup7 Signed-off-by: Anan Z <[email protected]> * fix ciGroup6 Signed-off-by: Anan Z <[email protected]> --------- Signed-off-by: Anan <[email protected]> Signed-off-by: Anan Z <[email protected]> * add missing snapshot (#5818) Signed-off-by: Anan Z <[email protected]> * fix pluign ftr tests (#5821) Signed-off-by: Anan Z <[email protected]> * update snapshot (#5824) Signed-off-by: abbyhu2000 <[email protected]> * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * dashboard expect Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Solve cigroup 7 flakiness (#5826) * test hover Signed-off-by: abbyhu2000 <[email protected]> * comment out other ci to speed up Signed-off-by: abbyhu2000 <[email protected]> * uncomment Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <[email protected]> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <[email protected]> * removes sub module from branch Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Persist line height (#5836) Signed-off-by: Ashwin P Chandran <[email protected]> * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <[email protected]> * nit Signed-off-by: Ashwin P Chandran <[email protected]> * update changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]> (cherry picked from commit e13dbff) Co-authored-by: Qingyang(Abby) Hu <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Feb 8, 2024
…5789) (#5839) * basic table working * basic styling * fix header column style * correctly display optional col header actions * move col to the right or left if applicable * add cell filter for and filter out buttons * add cell action on doc table, half working on toggle columns * sorting * Add toggling between legacy and new table According to #5739, add toggle using storage. * get rid of the console log * optimize cell filter logics * add more refactoring * remove an used line * some more table cell optimization * Initial UI fixes (#5758) * Table optimization with lazy loading (#5760) * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab * [Discover] Fix more UI (#5764) * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization * improved loader --------- * Change sort icon according to current sort conditions (#5772) * fix breadcrumb navigation (#5773) * Add pagination to discover embeddable (#5770) * Add pagination * fix an errir * small change * fix errors --------- * [Discover] Prevent wrapping of time series cells (#5779) * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows * [Discover] Display filter buttons at top right of the cell (#5784) * [Discover] Vertically align the details toggle button (#5785) * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells * Fix overflow problem of detailed doc --------- * update feedback msg (#5787) * Resolve sort, default sort and short dot (#5771) * [Discover] Fixes pagination style (#5778) * fixes pagination style * style-lint fix * fix react warning for unnecessary prop * Show total hit count and pass services in embeddable * removed unnecessary div --------- * add changelog * fix table column error * Fix pagination edge case * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? * change path to not include appstate * delete optional app state for single doc link too --------- * type fixes (#5795) * Update toggle to button (#5808) * Adds support for line count (#5814) * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 * fix ciGroup7 * fix ciGroup6 --------- * add missing snapshot (#5818) * fix pluign ftr tests (#5821) * update snapshot (#5824) * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 * fix functional 3 and 4 * dashboard expect --------- * Solve cigroup 7 flakiness (#5826) * test hover * comment out other ci to speed up * uncomment --------- * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal * renames datagrid settng to newDiscover setting * removes sub module from branch --------- * Persist line height (#5836) * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change * nit * update changelog --------- * fix table height persist on context page --------- (cherry picked from commit e13dbff) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Feb 21, 2024
…pensearch-project#5789) * basic table working Signed-off-by: abbyhu2000 <[email protected]> * basic styling Signed-off-by: abbyhu2000 <[email protected]> * fix header column style Signed-off-by: abbyhu2000 <[email protected]> * correctly display optional col header actions Signed-off-by: abbyhu2000 <[email protected]> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <[email protected]> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <[email protected]> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <[email protected]> * sorting Signed-off-by: abbyhu2000 <[email protected]> * Add toggling between legacy and new table According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]> * get rid of the console log Signed-off-by: abbyhu2000 <[email protected]> * optimize cell filter logics Signed-off-by: abbyhu2000 <[email protected]> * add more refactoring Signed-off-by: abbyhu2000 <[email protected]> * remove an used line Signed-off-by: abbyhu2000 <[email protected]> * some more table cell optimization Signed-off-by: abbyhu2000 <[email protected]> * Initial UI fixes (opensearch-project#5758) Signed-off-by: Ashwin P Chandran <[email protected]> * Table optimization with lazy loading (opensearch-project#5760) Signed-off-by: abbyhu2000 <[email protected]> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <[email protected]> * [Discover] Fix more UI (opensearch-project#5764) Signed-off-by: Ashwin P Chandran <[email protected]> * [Discover] Fixes table optimization (opensearch-project#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <[email protected]> * improved loader Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Change sort icon according to current sort conditions (opensearch-project#5772) Signed-off-by: abbyhu2000 <[email protected]> * fix breadcrumb navigation (opensearch-project#5773) Signed-off-by: abbyhu2000 <[email protected]> * Add pagination to discover embeddable (opensearch-project#5770) * Add pagination Signed-off-by: abbyhu2000 <[email protected]> * fix an errir Signed-off-by: abbyhu2000 <[email protected]> * small change Signed-off-by: abbyhu2000 <[email protected]> * fix errors Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Prevent wrapping of time series cells (opensearch-project#5779) Signed-off-by: Miki <[email protected]> * Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780) Signed-off-by: Miki <[email protected]> * Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <[email protected]> * [Discover] Display filter buttons at top right of the cell (opensearch-project#5784) Signed-off-by: Miki <[email protected]> * [Discover] Vertically align the details toggle button (opensearch-project#5785) Signed-off-by: Miki <[email protected]> * [Discover] Fix overflow of the expanded document (opensearch-project#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <[email protected]> * Fix overflow problem of detailed doc Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> * update feedback msg (opensearch-project#5787) Signed-off-by: Anan Z <[email protected]> * Resolve sort, default sort and short dot (opensearch-project#5771) Signed-off-by: Anan Z <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> * [Discover] Fixes pagination style (opensearch-project#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <[email protected]> * style-lint fix Signed-off-by: Ashwin P Chandran <[email protected]> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <[email protected]> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <[email protected]> * removed unnecessary div Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> * fix table column error Signed-off-by: abbyhu2000 <[email protected]> * Fix pagination edge case Signed-off-by: abbyhu2000 <[email protected]> * Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <[email protected]> * change path to not include appstate Signed-off-by: abbyhu2000 <[email protected]> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * type fixes (opensearch-project#5795) Signed-off-by: Ashwin P Chandran <[email protected]> * Update toggle to button (opensearch-project#5808) Signed-off-by: Ashwin P Chandran <[email protected]> * Adds support for line count (opensearch-project#5814) Signed-off-by: Ashwin P Chandran <[email protected]> * Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <[email protected]> * fix ciGroup7 Signed-off-by: Anan Z <[email protected]> * fix ciGroup6 Signed-off-by: Anan Z <[email protected]> --------- Signed-off-by: Anan <[email protected]> Signed-off-by: Anan Z <[email protected]> * add missing snapshot (opensearch-project#5818) Signed-off-by: Anan Z <[email protected]> * fix pluign ftr tests (opensearch-project#5821) Signed-off-by: Anan Z <[email protected]> * update snapshot (opensearch-project#5824) Signed-off-by: abbyhu2000 <[email protected]> * Fix functional 3 and 4 for discover legacy (opensearch-project#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * dashboard expect Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Solve cigroup 7 flakiness (opensearch-project#5826) * test hover Signed-off-by: abbyhu2000 <[email protected]> * comment out other ci to speed up Signed-off-by: abbyhu2000 <[email protected]> * uncomment Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Simplify feedback modal (opensearch-project#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <[email protected]> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <[email protected]> * removes sub module from branch Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Persist line height (opensearch-project#5836) Signed-off-by: Ashwin P Chandran <[email protected]> * Update table revert changelog (opensearch-project#5835) * Update table revert changelog updates changelog <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> --> <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <[email protected]> * nit Signed-off-by: Ashwin P Chandran <[email protected]> * update changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Feb 21, 2024
…pensearch-project#5789) * basic table working Signed-off-by: abbyhu2000 <[email protected]> * basic styling Signed-off-by: abbyhu2000 <[email protected]> * fix header column style Signed-off-by: abbyhu2000 <[email protected]> * correctly display optional col header actions Signed-off-by: abbyhu2000 <[email protected]> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <[email protected]> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <[email protected]> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <[email protected]> * sorting Signed-off-by: abbyhu2000 <[email protected]> * Add toggling between legacy and new table According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <[email protected]> * get rid of the console log Signed-off-by: abbyhu2000 <[email protected]> * optimize cell filter logics Signed-off-by: abbyhu2000 <[email protected]> * add more refactoring Signed-off-by: abbyhu2000 <[email protected]> * remove an used line Signed-off-by: abbyhu2000 <[email protected]> * some more table cell optimization Signed-off-by: abbyhu2000 <[email protected]> * Initial UI fixes (opensearch-project#5758) Signed-off-by: Ashwin P Chandran <[email protected]> * Table optimization with lazy loading (opensearch-project#5760) Signed-off-by: abbyhu2000 <[email protected]> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <[email protected]> * [Discover] Fix more UI (opensearch-project#5764) Signed-off-by: Ashwin P Chandran <[email protected]> * [Discover] Fixes table optimization (opensearch-project#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <[email protected]> * improved loader Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Change sort icon according to current sort conditions (opensearch-project#5772) Signed-off-by: abbyhu2000 <[email protected]> * fix breadcrumb navigation (opensearch-project#5773) Signed-off-by: abbyhu2000 <[email protected]> * Add pagination to discover embeddable (opensearch-project#5770) * Add pagination Signed-off-by: abbyhu2000 <[email protected]> * fix an errir Signed-off-by: abbyhu2000 <[email protected]> * small change Signed-off-by: abbyhu2000 <[email protected]> * fix errors Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Prevent wrapping of time series cells (opensearch-project#5779) Signed-off-by: Miki <[email protected]> * Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780) Signed-off-by: Miki <[email protected]> * Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <[email protected]> * [Discover] Display filter buttons at top right of the cell (opensearch-project#5784) Signed-off-by: Miki <[email protected]> * [Discover] Vertically align the details toggle button (opensearch-project#5785) Signed-off-by: Miki <[email protected]> * [Discover] Fix overflow of the expanded document (opensearch-project#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <[email protected]> * Fix overflow problem of detailed doc Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> * update feedback msg (opensearch-project#5787) Signed-off-by: Anan Z <[email protected]> * Resolve sort, default sort and short dot (opensearch-project#5771) Signed-off-by: Anan Z <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> * [Discover] Fixes pagination style (opensearch-project#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <[email protected]> * style-lint fix Signed-off-by: Ashwin P Chandran <[email protected]> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <[email protected]> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <[email protected]> * removed unnecessary div Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> * fix table column error Signed-off-by: abbyhu2000 <[email protected]> * Fix pagination edge case Signed-off-by: abbyhu2000 <[email protected]> * Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <[email protected]> * change path to not include appstate Signed-off-by: abbyhu2000 <[email protected]> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * type fixes (opensearch-project#5795) Signed-off-by: Ashwin P Chandran <[email protected]> * Update toggle to button (opensearch-project#5808) Signed-off-by: Ashwin P Chandran <[email protected]> * Adds support for line count (opensearch-project#5814) Signed-off-by: Ashwin P Chandran <[email protected]> * Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <[email protected]> * fix ciGroup7 Signed-off-by: Anan Z <[email protected]> * fix ciGroup6 Signed-off-by: Anan Z <[email protected]> --------- Signed-off-by: Anan <[email protected]> Signed-off-by: Anan Z <[email protected]> * add missing snapshot (opensearch-project#5818) Signed-off-by: Anan Z <[email protected]> * fix pluign ftr tests (opensearch-project#5821) Signed-off-by: Anan Z <[email protected]> * update snapshot (opensearch-project#5824) Signed-off-by: abbyhu2000 <[email protected]> * Fix functional 3 and 4 for discover legacy (opensearch-project#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <[email protected]> * dashboard expect Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Solve cigroup 7 flakiness (opensearch-project#5826) * test hover Signed-off-by: abbyhu2000 <[email protected]> * comment out other ci to speed up Signed-off-by: abbyhu2000 <[email protected]> * uncomment Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Simplify feedback modal (opensearch-project#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <[email protected]> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <[email protected]> * removes sub module from branch Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Persist line height (opensearch-project#5836) Signed-off-by: Ashwin P Chandran <[email protected]> * Update table revert changelog (opensearch-project#5835) * Update table revert changelog updates changelog <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> --> <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <[email protected]> * nit Signed-off-by: Ashwin P Chandran <[email protected]> * update changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Anan Z <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Anan <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Ganesh0107 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a html placeholder for default table.
Allow two switch types: 1) use advanced setting to disable legacy table 2) use toggle on discover page
After #5715 is done, we could replace the placeholder and merge it in.
Issues Resolved
#5716
Screenshot
switch-table.mov
Check List
yarn test:jestyarn test:jest_integration