[Datasource selector] Sort datasource option list alphabetically #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5719 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 3296 3296
Lines 63339 63343 +4
Branches 10087 10087
=======================================
+ Hits 42459 42465 +6
- Misses 18430 18432 +2
+ Partials 2450 2446 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuali925
approved these changes
Jan 22, 2024
| return { | ||
| ...dsGroup, | ||
| options: [...dsGroup.options].sort((ds1, ds2) => { | ||
| return ds1.label.localeCompare(ds2.label, undefined, { sensitivity: 'base' }); |
There was a problem hiding this comment.
base was the original behavior in 2.9?
There was a problem hiding this comment.
It uses lodash's sortBy without any addition settings which I believe is not using 'base' as I tested that for example 'a' vs 'A' will be sorted in different groups. For index patterns it's fine as there will be no Uppercase allowed plus a list of restrictions, but since we also introduced non index pattern datasource with some different, flexible naming restrictions, I figured this way should have the better support.
ashwin-pc
reviewed
Jan 22, 2024
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
mengweieric
force-pushed
the
feature/order-datasource-alphabatically
branch
from
7c6ed5e to
91e72c3
Compare
mengweieric
requested review from
ananzh,
kavilla,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
It's possible but currently we are pulling datasources through different APIs and then consolidate them from front end. With this implementation we will need to compose different queries to include sorting for different datasources. For now I think to sort them after consolidations will be relatively easier. |
Signed-off-by: Eric <[email protected]>
ashwin-pc
approved these changes
Jan 23, 2024
ananzh
approved these changes
Jan 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* sort datasource option list in each group alphabetically * add test for sorting * remove one datasource per test --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 058dfbc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* sort datasource option list in each group alphabetically * add test for sorting * remove one datasource per test --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 058dfbc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
…) (#5735) * sort datasource option list in each group alphabetically * add test for sorting * remove one datasource per test --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 058dfbc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]>
ananzh
pushed a commit
that referenced
this pull request
Jan 31, 2024
…) (#5734) * sort datasource option list in each group alphabetically * add test for sorting * remove one datasource per test --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 058dfbc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this pull request
Feb 5, 2024
…nsearch-project#5719) * sort datasource option list in each group alphabetically * add test for sorting * remove one datasource per test --------- Signed-off-by: Eric <[email protected]> Signed-off-by: yujin-emma <[email protected]>
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort datasource option list in each group alphabetically.
Issues Resolved
#5609
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration