Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b2… #5668

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

zhyuanqi
Copy link
Collaborator

@zhyuanqi zhyuanqi commented Jan 8, 2024

Description

Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry.

Issues Resolved

No related issue with it.

Testing the changes

Since we only delete old record of id 90943e30-9a47-11e8-b64d-95841ca0b247. No record still exists on line 404. Visualization stays the same

Check List

  • All tests pass
    • [N] yarn test:jest (Two tests failed in my local. log_rotator.test.ts and create_os_package_tasks.test.ts. I don't think they are related to my change though)
    • [Y] yarn test:jest_integration
  • [N] New functionality includes testing.
  • [N] New functionality has been documented.
  • [Y] Update CHANGELOG.md
  • [Y] Commits are signed per the DCO using --signoff

…47 appears twice on line 273 and 404. Duplicate entry.

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
@zhyuanqi
Copy link
Collaborator Author

zhyuanqi commented Jan 8, 2024

Previous pull request: #5591

ZilongX
ZilongX previously approved these changes Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2a44ae) 67.02% compared to head (bd8e6d9) 67.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5668   +/-   ##
=======================================
  Coverage   67.02%   67.02%           
=======================================
  Files        3294     3294           
  Lines       63307    63307           
  Branches    10071    10071           
=======================================
  Hits        42430    42430           
  Misses      18431    18431           
  Partials     2446     2446           
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.19% <ø> (ø)
Linux_4 35.34% <ø> (ø)
Windows_1 35.26% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 43.88% <ø> (ø)
Windows_4 35.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Flyingliuhub Flyingliuhub merged commit 09b64a4 into opensearch-project:main Jan 9, 2024
69 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2024
#5668)

* Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry.

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

---------

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit 09b64a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
manasvinibs pushed a commit that referenced this pull request Jan 10, 2024
#5668) (#5676)

* Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry.

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

---------

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Co-authored-by: ZilongX <[email protected]>
(cherry picked from commit 09b64a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma pushed a commit to yujin-emma/OpenSearch-Dashboards that referenced this pull request Feb 5, 2024
opensearch-project#5668)

* Remove duplicate sample data as id 90943e30-9a47-11e8-b64d-95841ca0b247 appears twice on line 273 and 404. Duplicate entry.

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>

---------

Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
Co-authored-by: ZilongX <[email protected]>
Signed-off-by: yujin-emma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants