-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON #5662
Merged
manasvinibs
merged 2 commits into
opensearch-project:main
from
joshuarrrr:chore/normalize-theme-var-loading
Jan 10, 2024
Merged
Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON #5662
manasvinibs
merged 2 commits into
opensearch-project:main
from
joshuarrrr:chore/normalize-theme-var-loading
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
January 5, 2024 18:41
Signed-off-by: Josh Romero <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5662 +/- ##
==========================================
- Coverage 67.02% 67.02% -0.01%
==========================================
Files 3294 3294
Lines 63309 63309
Branches 10071 10071
==========================================
- Hits 42435 42433 -2
- Misses 18430 18431 +1
- Partials 2444 2445 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
approved these changes
Jan 10, 2024
manasvinibs
approved these changes
Jan 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit a4ae399) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit a4ae399) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
that referenced
this pull request
Jan 31, 2024
… (#5680) * Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON * add changelog --------- (cherry picked from commit a4ae399) Signed-off-by: Josh Romero <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this pull request
Feb 5, 2024
…search-project#5662) * Chore (ui-shared-deps): Clean up direct usage of OUI theme JSON Signed-off-by: Josh Romero <[email protected]> * add changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> Signed-off-by: yujin-emma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #5652, I looked into the various ways we consume OUI themes. One thing I realized is that, when using the JSON files to fetch SASS variables, we should always do it via
ui-shared-deps
, which is dark/light-mode aware. This change fixes the imports, although further refactoring is deferred to the linked issue: #5661Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration