Require front-matter v4.0.2, fix resolutions #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed 7d6105e |
kavilla
reviewed
Jun 28, 2021
| "**/graphql-toolkit/lodash": "^4.17.15", | ||
| "**/hoist-non-react-statics": "^3.3.2", | ||
| "**/immer": "^8.0.1", | ||
| "**/isomorphic-fetch/node-fetch": "^2.6.1", | ||
| "**/istanbul-instrumenter-loader/schema-utils": "^1.0.0", | ||
| "**/load-grunt-config/lodash": "^4.17.20", | ||
| "**/locutus": "^2.0.14", |
There was a problem hiding this comment.
unnecessary resolutions for dependencies
Just verifying that this was unnecessary #460
There was a problem hiding this comment.
Yeah that's correct, the correct way to bump the minor or patch version is to remove the dependency from the lockfile and then re-run bootstrap. That's what dependabot does as well: https://medium.com/@ayushya/upgrading-javascript-packages-deep-dependencies-using-yarn-8b5983d5fb6b
tmarkley
force-pushed
the
deps-front-matter
branch
from
7d6105e to
2be6e98
Compare
|
✅ DCO Check Passed 2be6e98 |
tmarkley
force-pushed
the
deps-front-matter
branch
from
2be6e98 to
83f40e4
Compare
|
✅ DCO Check Passed 83f40e4 |
kavilla
previously approved these changes
Jun 28, 2021
ananzh
previously approved these changes
Jun 28, 2021
tmarkley
force-pushed
the
deps-front-matter
branch
from
83f40e4 to
2709780
Compare
|
✅ DCO Check Passed 2709780 |
ananzh
previously approved these changes
Jun 29, 2021
kavilla
previously approved these changes
Jun 29, 2021
tmarkley
force-pushed
the
deps-front-matter
branch
from
2709780 to
0ae8375
Compare
|
✅ DCO Check Passed dfc1f95 |
Addresses [WS-2020-0341](jxson/front-matter@f71652c) Also removes unnecessary resolutions for dependencies that didn't have conflicts. `front-matter` 2.1.2 is a downstream dependency of `sass-lint` which is an unmaintained repo without any newer versions. I've opened opensearch-project#551 to address this as a longer-term solution. Upgrades [front-matter](https://github.com/jxson/front-matter) from 2.1.2 to 4.0.2 - [Release notes](https://github.com/jxson/front-matter/releases) - [Commits](jxson/front-matter@v2.1.2...v4.0.2) Signed-off-by: Tommy Markley <[email protected]>
tmarkley
force-pushed
the
deps-front-matter
branch
from
dfc1f95 to
a174ce9
Compare
|
✅ DCO Check Passed a174ce9 |
ananzh
approved these changes
Jun 30, 2021
kavilla
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses WS-2020-0341
Also removes unnecessary resolutions for dependencies that didn't have conflicts.
front-matter2.1.2 is a downstream dependency ofsass-lintwhich is an unmaintained repo without any newer versions. I've opened #551 to address this as a longer-term solution.Upgrades front-matter from 2.1.2 to 4.0.2
Before
Testing
Issues Resolved
N/A
Check List