[osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5508

MadaniKK · 2023-11-18T23:49:15Z

Description

Before, when we switched between data samples(indexPattern), the previously selected columns in the canvas area got cleared regardless of the setting of MODIFY_COLUMN_ON_SWICTH.

Expected behavior

When MODIFY_COLUMN_ON_SWICTH is off, the previous selected columns should be kept in the canvas area. The fields in the left sidebar should always only show the existing fields in the new indexPattern regardless of the MODIFY_COLUMN_ON_SWITCH.

Issues Resolved

Issue #5268

Screenshot

When MODIFY_COLUMN_ON_SWICTH is off/false:
We can still see columns from the previously chosen indexPattern in the canvas area

When MODIFY_COLUMN_ON_SWICTH is on/true:
only shared columns would be preserved in the canvas area

Testing the changes

go to the advanced setting to modify MODIFY_COLUMN_ON_SWICTH as shown in issue #5268
modify the side nav to see the changes.

Check List

All tests pass
- [ x] yarn test:jest
- [ x] yarn test:jest_integration
[ x] New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
[ x] Commits are signed per the DCO using --signoff

…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:

Signed-off-by: qiwen li <[email protected]>

codecov · 2023-11-19T00:02:35Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (28c1fbb) 67.02% compared to head (8183469) 67.02%.

Files	Patch %	Lines
...pplication/view_components/utils/filter_columns.ts	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5508      +/-   ##
==========================================
- Coverage   67.02%   67.02%   -0.01%     
==========================================
  Files        3294     3294              
  Lines       63306    63309       +3     
  Branches    10069    10071       +2     
==========================================
+ Hits        42431    42433       +2     
  Misses      18431    18431              
- Partials     2444     2445       +1

Flag	Coverage Δ
Linux_1	`35.24% <ø> (ø)`
Linux_2	`55.19% <ø> (ø)`
Linux_3	`43.86% <75.00%> (+<0.01%)`	⬆️
Linux_4	`35.34% <ø> (ø)`
Windows_1	`35.26% <ø> (ø)`
Windows_2	`55.15% <ø> (ø)`
Windows_3	`43.88% <75.00%> (+<0.01%)`	⬆️
Windows_4	`35.34% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/discover/public/application/components/sidebar/discover_sidebar.tsx

Signed-off-by: qiwen li <[email protected]>

Signed-off-by: Qiwen Li <[email protected]>

…n are only shown in canvas area Signed-off-by: qiwen li <[email protected]>

… fix-5268-2 merge

…s into fix-5268-2 merge

CHANGELOG.md

src/plugins/discover/public/application/components/sidebar/discover_sidebar.tsx

src/plugins/discover/public/application/view_components/utils/filter_columns.ts

Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]>

Signed-off-by: Qiwen Li <[email protected]>

…s into fix-5268-2 merge

Signed-off-by: Anan Zhuang <[email protected]>

Signed-off-by: Ashwin P Chandran <[email protected]>

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

@param

…CH (#5508) (#5746) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@param

…CH (#5508) (#5638) * Revert "[Data Explorer][Discover 2.0] Fix issues when change index pattern (#4875) (#4885)" This reverts commit 0102a32. try revert: * [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH Signed-off-by: qiwen li <[email protected]> * fix deps Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Signed-off-by: Qiwen Li <[email protected]> * modify to match discover legacy behavior, columns from previous column are only shown in canvas area Signed-off-by: qiwen li <[email protected]> * Update CHANGELOG.md Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]> * removed unused variables, added comments and @param Signed-off-by: Qiwen Li <[email protected]> --------- Signed-off-by: qiwen li <[email protected]> Signed-off-by: Qiwen Li <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 34994f8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

MadaniKK added 2 commits November 18, 2023 16:15

Revert "[Data Explorer][Discover 2.0] Fix issues when change index pa…

9f7d04a

…ttern (opensearch-project#4875) (opensearch-project#4885)" This reverts commit 0102a32. try revert:

[osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH

0a2b214

Signed-off-by: qiwen li <[email protected]>

MadaniKK requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy and curq as code owners November 18, 2023 23:49

github-actions bot added the first-time-contributor label Nov 18, 2023

SuZhou-Joe reviewed Nov 20, 2023

View reviewed changes

src/plugins/discover/public/application/components/sidebar/discover_sidebar.tsx Outdated Show resolved Hide resolved

MadaniKK added 5 commits November 20, 2023 18:46

fix deps

655f657

Signed-off-by: qiwen li <[email protected]>

Update CHANGELOG.md

4aadcc9

Signed-off-by: Qiwen Li <[email protected]>

modify to match discover legacy behavior, columns from previous colum…

517eeeb

…n are only shown in canvas area Signed-off-by: qiwen li <[email protected]>

Merge branch 'main' of github.com:MadaniKK/OpenSearch-Dashboards into…

d58e617

… fix-5268-2 merge

Merge branch 'fix-5268-2' of github.com:MadaniKK/OpenSearch-Dashboard…

53a3e9c

…s into fix-5268-2 merge

MadaniKK requested a review from SuZhou-Joe November 21, 2023 23:01

ananzh reviewed Nov 22, 2023

View reviewed changes

MadaniKK and others added 3 commits November 21, 2023 19:39

Update CHANGELOG.md

bb5dcdf

Co-authored-by: Anan Zhuang <[email protected]> Signed-off-by: Qiwen Li <[email protected]>

removed unused variables, added comments and @param

3e7ffd9

Signed-off-by: Qiwen Li <[email protected]>

Merge branch 'fix-5268-2' of github.com:MadaniKK/OpenSearch-Dashboard…

5d34eab

…s into fix-5268-2 merge

Merge branch 'main' into fix-5268-2

3c44a09

Signed-off-by: Anan Zhuang <[email protected]>

MadaniKK requested a review from bandinib-amzn as a code owner December 14, 2023 19:23

ananzh previously approved these changes Dec 14, 2023

View reviewed changes

ananzh added discover for discover reinvent bug Something isn't working v2.12.0 backport 2.x labels Dec 14, 2023

ashwin-pc previously approved these changes Dec 14, 2023

View reviewed changes

Merge branch 'main' into fix-5268-2

5138453

Signed-off-by: Anan Zhuang <[email protected]>

ananzh dismissed stale reviews from ashwin-pc and themself via 5138453 December 14, 2023 23:15

ananzh previously approved these changes Dec 14, 2023

View reviewed changes

SuZhou-Joe previously approved these changes Dec 15, 2023

View reviewed changes

Merge branch 'main' into fix-5268-2

8183469

Signed-off-by: Ashwin P Chandran <[email protected]>

ashwin-pc dismissed stale reviews from SuZhou-Joe and ananzh via 8183469 December 19, 2023 23:54

ananzh approved these changes Dec 21, 2023

View reviewed changes

ashwin-pc approved these changes Dec 21, 2023

View reviewed changes

ashwin-pc merged commit 34994f8 into opensearch-project:main Dec 21, 2023
67 checks passed

opensearch-trigger-bot bot mentioned this pull request Dec 21, 2023

[Backport 2.x] [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5638

Merged

ananzh mentioned this pull request Dec 22, 2023

[BUG] [Data Explorer] Modify columns on switch #5268

Closed

ananzh mentioned this pull request Jan 19, 2024

[Meta][Discover][Functional Test] Capturing Customer Feedback and Bugs into tests for Discover #5713

Open

11 tasks

ananzh added the backport 2.11 label Jan 26, 2024

opensearch-trigger-bot bot mentioned this pull request Jan 26, 2024

[Backport 2.11] [osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5746

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5508

[osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5508

MadaniKK commented Nov 18, 2023 •

edited

Loading

codecov bot commented Nov 19, 2023 •

edited

Loading

[osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5508

[osci23] implmented advance setting in Dicover: MODIFY_COLUMN_ON_SWITCH #5508

Conversation

MadaniKK commented Nov 18, 2023 • edited Loading

Description

Expected behavior

Issues Resolved

Screenshot

Testing the changes

Check List

codecov bot commented Nov 19, 2023 • edited Loading

Codecov Report

MadaniKK commented Nov 18, 2023 •

edited

Loading

codecov bot commented Nov 19, 2023 •

edited

Loading