Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual][Backport 2.x][Decouple] Add new core service to expose functionality to verify plugin compatibility with OpenSearch plugins #5503

Merged

Conversation

manasvinibs
Copy link
Member

Description

Backport of #4710

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@manasvinibs manasvinibs added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b635c4b) 66.98% compared to head (fc3a39f) 67.00%.

Files Patch % Lines
...cross_compatibility/cross_compatibility_service.ts 90.32% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #5503      +/-   ##
==========================================
+ Coverage   66.98%   67.00%   +0.01%     
==========================================
  Files        3287     3289       +2     
  Lines       63266    63298      +32     
  Branches    10052    10056       +4     
==========================================
+ Hits        42378    42411      +33     
+ Misses      18449    18448       -1     
  Partials     2439     2439              
Flag Coverage Δ
Linux_1 35.24% <ø> (ø)
Linux_2 55.18% <93.33%> (+0.05%) ⬆️
Linux_3 43.79% <8.88%> (-0.03%) ⬇️
Linux_4 35.47% <8.88%> (-0.03%) ⬇️
Windows_1 35.27% <ø> (ø)
Windows_2 55.14% <93.33%> (+0.05%) ⬆️
Windows_3 43.81% <8.88%> (-0.04%) ⬇️
Windows_4 35.47% <8.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…gin compatibility with OpenSearch plugins (opensearch-project#4710)

* Allow plugin manifest config to define semver compatible OpenSearch plugin and verify if it is installed on the cluster

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Add new core service to expose functionality to verify plugin compatibility with OpenSearch plugins

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* Add readme doc for cross compatibility service

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

---------

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit cf4f929)
@manasvinibs manasvinibs force-pushed the backport/backport-4710-to-2.x branch from a09a53b to fc3a39f Compare November 27, 2023 20:21
@ananzh ananzh merged commit 901a890 into opensearch-project:2.x Dec 13, 2023
65 of 66 checks passed
@ananzh
Copy link
Member

ananzh commented Dec 13, 2023

Thanks @SuZhou-Joe for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decouple enhancement New feature or request Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants