Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove empty suggestion history #5349

Merged
merged 6 commits into from
Dec 13, 2023
Merged

[Fix] Remove empty suggestion history #5349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d8c5e49
Add search input filter
willie-hung Oct 21, 2023
35f2bbd
Add CHANGELOG.md
willie-hung Oct 21, 2023
3f75024
Merge branch 'main' into issue5348
joshuarrrr Nov 13, 2023
16d144c
Add tests for empty suggestions
willie-hung Nov 20, 2023
fe7a80c
Add code comment
willie-hung Nov 20, 2023
7785e69
Merge branch 'main' into issue5348
ananzh Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [BUG][Fuctional Test] Make setDefaultAbsoluteRange more robust and update doc views tests ([#5242](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5242))
- [BUG] Add platform "darwin-arm64" to unit test ([#5290](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5290))
- [BUG][Dev Tool] Add dev tool documentation link to dev tool's help menu [#5166](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5166)
- [BUG] Fix empty suggestion history when querying in search bar [#5349](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5349)

### 🚞 Infrastructure

Expand Down
4 changes: 4 additions & 0 deletions src/plugins/data/public/ui/typeahead/suggestion_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
}

export function SuggestionComponent(props: Props) {
if (!props.suggestion.text.trim()) {
return null;

Check warning on line 65 in src/plugins/data/public/ui/typeahead/suggestion_component.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/data/public/ui/typeahead/suggestion_component.tsx#L65 

Added line #L65 was not covered by tests
}

willie-hung marked this conversation as resolved.
Show resolved Hide resolved
return (
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/interactive-supports-focus
<div
Expand Down
Loading