Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Enable unit test suite: get_data_telemetry.test.ts #530

Merged
merged 1 commit into from
Jun 24, 2021
Merged

[Test] Enable unit test suite: get_data_telemetry.test.ts #530

merged 1 commit into from
Jun 24, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jun 22, 2021

Description

All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_data_telemetry.test.ts.

Signed-off-by: Anan Zhuang [email protected]

Issues Resolved

#514

Test results

unit test for get_data_telemetry.test.ts

yarn test:jest /home/anan/work/OpenSearch-Dashboards/src/plugins/telemetry/server/telemetry_collection/get_data_telemetry/get_data_telemetry.test.ts
yarn run v1.22.10
$ node scripts/jest /home/anan/work/OpenSearch-Dashboards/src/plugins/telemetry/server/telemetry_collection/get_data_telemetry/get_data_telemetry.test.ts
 PASS  src/plugins/telemetry/server/telemetry_collection/get_data_telemetry/get_data_telemetry.test.ts
  get_data_telemetry
    DATA_DATASETS_INDEX_PATTERNS
      Pattern .ent-search-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (2 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern .app-search-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *magento2*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *magento*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *shopify*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *wordpress*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *drupal*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *joomla*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *search*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (2 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *sharepoint*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *squarespace*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *sitecore*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *weebly*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern *acquia*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern filebeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern metricbeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern apm-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern functionbeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern heartbeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern logstash-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern fluentd*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern telegraf*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern prometheusbeat*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern fluentbit*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern *nginx*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *apache*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern endgame-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern logs-endpoint.*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern metrics-endpoint.*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern .siem-signals-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern auditbeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern winlogbeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern packetbeat-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *tomcat*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *artifactory*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *aruba*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *barracuda*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *bluecoat*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern arcsight-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern *checkpoint*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *cisco*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *citrix*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *cyberark*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern *cylance*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *fireeye*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *fortinet*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *infoblox*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *kaspersky*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *mcafee*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *paloaltonetworks*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern pan-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern pan_*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern pan.*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern rsa.*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern rsa-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern rsa_*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern snort-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern logstash-snort*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *sonicwall*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *sophos*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern squid-*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern squid_*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern squid.*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *symantec*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *tippingpoint*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *trendmicro*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *tripwire*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *zscaler*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE (1 ms)
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *zeek*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *sigma_doc*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern ecs-corelight*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *suricata*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical (1 ms)
      Pattern *wazuh*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
      Pattern *meow*
        ✓ there should only be one in DATA_DATASETS_INDEX_PATTERNS_UNIQUE
        ✓ when a document is duplicated, the duplicates should be identical
    buildDataTelemetryPayload
      ✓ return the base object when no indices provided (1 ms)
      ✓ return the base object when no matching indices provided (2 ms)
      ✓ matches some indices and puts them in their own category (2 ms)
    getDataTelemetry
      ✓ it returns the base payload (all 0s) because no indices are found (27 ms)
      ✓ can only see the index mappings, but not the stats (16 ms)
      ✓ can see the mappings and the stats (14 ms)
      ✓ find an index that does not match any index pattern but has mappings metadata (41 ms)
      ✓ return empty array when there is an error (17 ms)

Test Suites: 1 passed, 1 total
Tests:       162 passed, 162 total
Snapshots:   0 total
Time:        2.583 s

Overall test result:
Screen Shot 2021-06-21 at 10 42 42 PM

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@ananzh
[Test] Enable unit test suite:get_data_telemetry.test.ts (opensearch-…
d37892b 
…project#514)

All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_data_telemetry.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh requested review from tmarkley, kavilla and boktorbb June 22, 2021 15:10
@ananzh ananzh self-assigned this Jun 22, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed d37892b

@ananzh ananzh mentioned this pull request Jun 23, 2021
Closed
26 tasks
@kavilla kavilla linked an issue Jun 23, 2021 that may be closed by this pull request
[Test] unit test get_data_telemetry.test.ts is skipped now #514
Closed
@ananzh ananzh merged commit 76eb0e5 into opensearch-project:main Jun 24, 2021
kavilla pushed a commit that referenced this pull request Jun 26, 2021
@ananzh @kavilla
[Test] Enable unit test suite:get_data_telemetry.test.ts (#514) (#530)
d0e799e 
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_data_telemetry.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
kavilla pushed a commit that referenced this pull request Jun 26, 2021
@ananzh @kavilla
[Test] Enable unit test suite:get_data_telemetry.test.ts (#514) (#530)
a229698 
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR checks and enables
get_data_telemetry.test.ts.

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh deleted the i-514 branch February 23, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@tmarkley tmarkley tmarkley approved these changes

@boktorbb boktorbb Awaiting requested review from boktorbb

Assignees

@ananzh ananzh

Labels
test:unit v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Test] unit test get_data_telemetry.test.ts is skipped now
4 participants
@ananzh @opensearch-ci-bot @tmarkley @kavilla