[Data Explorer] Removed X icon in data source selection. #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhilash <[email protected]>
Abilashinamdar
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Codecov Report
@@ Coverage Diff @@
## main #5238 +/- ##
==========================================
- Coverage 66.78% 66.74% -0.04%
==========================================
Files 3284 3284
Lines 63092 63092
Branches 10048 10048
==========================================
- Hits 42133 42109 -24
- Misses 18491 18586 +95
+ Partials 2468 2397 -71
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@Abilashinamdar wow thanks! this is a really quick and good fix. Totally missed that prop. Can you add a changelog for your change? |
Signed-off-by: Abhilash <[email protected]>
@ashwin-pc , I have Updated the changelog.md. |
Signed-off-by: Ashwin P Chandran <[email protected]>
ashwin-pc
changed the title
ashwin-pc
added
backport 2.x
data explorer
Signed-off-by: Miki <[email protected]>
AMoo-Miki
approved these changes
Oct 10, 2023
ananzh
approved these changes
Oct 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
* removed X icon in data source selection. Signed-off-by: Abhilash <[email protected]> * updated changelog Signed-off-by: Abhilash <[email protected]> * Update CHANGELOG.md Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Abhilash <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Abhilash <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit df08387) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
* removed X icon in data source selection. Signed-off-by: Abhilash <[email protected]> * updated changelog Signed-off-by: Abhilash <[email protected]> * Update CHANGELOG.md Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Abhilash <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Abhilash <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit df08387) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Oct 10, 2023
* removed X icon in data source selection. --------- Signed-off-by: Abhilash <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Abhilash <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit df08387) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this pull request
Oct 10, 2023
* removed X icon in data source selection. Signed-off-by: Abhilash <[email protected]> * updated changelog Signed-off-by: Abhilash <[email protected]> * Update CHANGELOG.md Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Abhilash <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Abhilash <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit df08387) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed Discover datasource selector X icon
Issues Resolved
fixes #5229
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration