-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSCI] Remove ftr test from PR template #5217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Deng <[email protected]>
Signed-off-by: Leo Deng <[email protected]>
Leo7Deng
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
October 4, 2023 21:05
joshuarrrr
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some small corrections of the changelog, otherwise looks good!
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]>
curq
approved these changes
Oct 5, 2023
ananzh
approved these changes
Oct 5, 2023
@AMoo-Miki @joshuarrrr should this be tagged |
joshuarrrr
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* removed ftr test step from PR template Signed-off-by: Leo Deng <[email protected]> * change changelog Signed-off-by: Leo Deng <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]> --------- Signed-off-by: Leo Deng <[email protected]> Signed-off-by: Leo Deng <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 6268794) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
* removed ftr test step from PR template Signed-off-by: Leo Deng <[email protected]> * change changelog Signed-off-by: Leo Deng <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]> --------- Signed-off-by: Leo Deng <[email protected]> Signed-off-by: Leo Deng <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Willie Hung <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 7, 2023
* removed ftr test step from PR template Signed-off-by: Leo Deng <[email protected]> * change changelog Signed-off-by: Leo Deng <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]> --------- Signed-off-by: Leo Deng <[email protected]> Signed-off-by: Leo Deng <[email protected]> Co-authored-by: Josh Romero <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Oct 10, 2023
* removed ftr test step from PR template Signed-off-by: Leo Deng <[email protected]> * change changelog Signed-off-by: Leo Deng <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]> --------- Signed-off-by: Leo Deng <[email protected]> Signed-off-by: Leo Deng <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 6268794) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed ftr test step from PR template
Issues Resolved
fixes #5210
Screenshot
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr