-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSCI] Remove unused tutorials #5212
Conversation
@@ -36,7 +36,6 @@ import { | |||
ScopedTutorialContextFactory, | |||
} from './lib/tutorials_registry_types'; | |||
import { tutorialSchema } from './lib/tutorial_schema'; | |||
import { builtInTutorials } from '../../tutorials/register'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an unused import, and also the only usage of tutorials under src/plugins/home/server/tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CMDWillYang Either in this PR, or as a standalone followup, can you also delete this comment:
OpenSearch-Dashboards/src/plugins/home/server/services/tutorials/tutorials_registry.ts
Lines 97 to 100 in 0ff9bc5
// pre-populate with built in tutorials | |
// TODO: [RENAMEME] Need prod urls. | |
// https://github.com/opensearch-project/OpenSearch-Dashboards/issues/335 | |
// this.tutorialProviders.push(...builtInTutorials); |
…als/logos Signed-off-by: CMDWillYang <[email protected]>
Signed-off-by: CMDWillYang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5212 +/- ##
==========================================
- Coverage 66.81% 66.79% -0.03%
==========================================
Files 3286 3286
Lines 63148 63148
Branches 10054 10054
==========================================
- Hits 42191 42178 -13
- Misses 18475 18486 +11
- Partials 2482 2484 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor suggestion on the changelog entry.
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: CMDWillYang <[email protected]>
LGTM as well! |
@CMDWillYang Can you open a new issue for discussing what to do with these? I agree that we should probably handle them separately, and can add some additional context. |
* removed unused content under src/plugins/home/server/tutorials Signed-off-by: CMDWillYang <[email protected]> * removed unused svg assets under src/plugins/home/public/assets/tutorials/logos Signed-off-by: CMDWillYang <[email protected]> * updated changelog Signed-off-by: CMDWillYang <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: CMDWillYang <[email protected]> --------- Signed-off-by: CMDWillYang <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 3c0211b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* removed unused content under src/plugins/home/server/tutorials Signed-off-by: CMDWillYang <[email protected]> * removed unused svg assets under src/plugins/home/public/assets/tutorials/logos Signed-off-by: CMDWillYang <[email protected]> * updated changelog Signed-off-by: CMDWillYang <[email protected]> * Update CHANGELOG.md Co-authored-by: Josh Romero <[email protected]> Signed-off-by: CMDWillYang <[email protected]> --------- Signed-off-by: CMDWillYang <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 3c0211b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* removed unused content under src/plugins/home/server/tutorials * removed unused svg assets under src/plugins/home/public/assets/tutorials/logos --------- Signed-off-by: CMDWillYang <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 3c0211b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Removed unused tutorials from:
src/plugins/home/server/tutorials
src/plugins/home/public/assets/tutorials/logos
Issues Resolved
fixes #4448
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr