Fix test failures in #5177

[AMoo-Miki]

Re #5177

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[ashwin-pc]

I'm looking at the last test run for #5177 and no test failed there. Also savedSearch is declared twice yes, but can you remove the other declaration of it instead of this one? A fix anan made will have a conflict here otherwise.

[codecov]

Codecov Report

Merging #5194 (baa9fbe) into 2.x (ab84ea1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #5194   +/-   ##
=======================================
  Coverage   66.80%   66.80%           
=======================================
  Files        3278     3278           
  Lines       63042    63042           
  Branches    10028    10028           
=======================================
  Hits        42116    42116           
+ Misses      18541    18461   -80     
- Partials     2385     2465   +80     

Flag	Coverage Δ
Linux_1	35.32% <ø> (ø)
Linux_2	55.26% <ø> (ø)
Linux_3	43.76% <ø> (ø)
Linux_4	35.55% <ø> (ø)
Windows_1	35.33% <ø> (ø)
Windows_2	55.23% <ø> (ø)
Windows_3	43.76% <ø> (ø)
Windows_4	35.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

[kavilla]

I'm looking at the last test run for #5177 and no test failed there. Also savedSearch is declared twice yes, but can you remove the other declaration of it instead of this one? A fix anan made will have a conflict here otherwise.

i think the fix might have gotten merged prior to the deangular.

[kavilla]

do the other changes from the original PR have no impact?