[Dashboard] Fix bugs on removing pinned global filters on dashboard page #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
abbyhu2000
added
de-angular
Codecov Report
@@ Coverage Diff @@
## main #5143 +/- ##
==========================================
- Coverage 66.74% 66.72% -0.03%
==========================================
Files 3278 3278
Lines 62985 62988 +3
Branches 10029 10029
==========================================
- Hits 42040 42027 -13
- Misses 18475 18490 +15
- Partials 2470 2471 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
abbyhu2000
added
the
Skip-Changelog
ashwin-pc
reviewed
Sep 28, 2023
| @@ -193,6 +193,17 @@ export const useDashboardAppAndGlobalState = ({ | |||
|
|
|||
| subscriptions.add(stopSyncingFromTimeFilters); | |||
|
|
|||
| const stopSyncingFromGlobalFilters = filterManager.getUpdates$().subscribe(() => { | |||
There was a problem hiding this comment.
Shouldnt we unsubscribe from this when exiting the hook?
There was a problem hiding this comment.
i did unsubscribe by subscriptions.add(stopSyncingFromGlobalFilters); and subscriptions.unsubscribe();
ananzh
approved these changes
Sep 29, 2023
AMoo-Miki
approved these changes
Oct 2, 2023
|
@abbyhu2000 any plans to also add a regression test for this? Maybe in the functional tests? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit ab925eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
added a commit
that referenced
this pull request
Oct 3, 2023
(cherry picked from commit ab925eb) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]>
Leo7Deng
pushed a commit
to Leo7Deng/OpenSearch-Dashboards
that referenced
this pull request
Oct 4, 2023
Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]>
Leo7Deng
pushed a commit
to Leo7Deng/OpenSearch-Dashboards
that referenced
this pull request
Oct 4, 2023
Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Leo Deng <[email protected]>
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Willie Hung <[email protected]>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 7, 2023
Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Josh Romero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the error removing pinned global filters.
Previously removing pinned global filters needs a refresh for it to be effective on the dashboard because it does not get updated immediately from global states to the dashboard container. Previously the dashboard container only listens to the app filters, this PR adds a listener on the global filter for the dashboard container.
Issues Resolved
resolves #4767
Screenshot
Screen.Recording.2023-09-27.at.10.34.53.PM.mov