[Data Explorer][Discover][Functional Test] Fix ciGroup7 #5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananzh
requested review from
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
ananzh
added
test:functional
data explorer
ananzh
added
discover
Issue Resolve opensearch-project#5129 Signed-off-by: Anan Zhuang <[email protected]>
ananzh
force-pushed
the
feature/deangular-ciGroup7
branch
from
34e9355 to
b9ad527
Compare
Codecov Report
@@ Coverage Diff @@
## feature/deangular #5131 +/- ##
=====================================================
+ Coverage 66.66% 66.69% +0.02%
=====================================================
Files 3283 3283
Lines 63059 63059
Branches 10031 10031
=====================================================
+ Hits 42040 42058 +18
+ Misses 18550 18542 -8
+ Partials 2469 2459 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
ashwin-pc
approved these changes
Sep 27, 2023
Signed-off-by: Anan Zhuang <[email protected]>
ashwin-pc
merged commit 5fe2fae
into
opensearch-project:feature/deangular
51 of 52 checks passed
ashwin-pc
added a commit
that referenced
this pull request
Sep 29, 2023
* Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]>
ashwin-pc
added a commit
to ashwin-pc/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2023
* Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve opensearch-project#4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve opensearch-project#5098 opensearch-project#5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve opensearch-project#5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (opensearch-project#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (opensearch-project#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (opensearch-project#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve opensearch-project#5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085) * Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (opensearch-project#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from opensearch-project#5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <[email protected]>
8 tasks
AMoo-Miki
pushed a commit
that referenced
this pull request
Oct 4, 2023
* [Deangular] OSD without angular (#5086) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <[email protected]> * fixes snapshot Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]>
AMoo-Miki
pushed a commit
that referenced
this pull request
Oct 4, 2023
* [Deangular] OSD without angular (#5086) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <[email protected]> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <[email protected]> * remove discover folder in config file Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <[email protected]> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <[email protected]> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <[email protected]> * fix 1 Signed-off-by: abbyhu2000 <[email protected]> * fix anchor test Signed-off-by: abbyhu2000 <[email protected]> * fix cigroup1 Signed-off-by: abbyhu2000 <[email protected]> * address comments Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <[email protected]> * fix error Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <[email protected]> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <[email protected]> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <[email protected]> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <[email protected]> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <[email protected]> * restore _discover_navigation Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <[email protected]> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Cameron Reed <[email protected]> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <[email protected]> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <[email protected]> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <[email protected]> * fixes snapshot Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Zashary Maskus-Lavin <[email protected]> Signed-off-by: Cameron Reed <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Zashary Maskus-Lavin <[email protected]> Co-authored-by: Cameron Reed <[email protected]> Co-authored-by: Cameron Reed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
#5129
Description
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr