-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Enable unit test suite: telemetry_service.test.ts #502
Conversation
✅ DCO Check Passed 7971c22 |
src/plugins/telemetry/public/services/telemetry_service.test.ts
Outdated
Show resolved
Hide resolved
You commented:
Any idea if this can be addressed? |
…project#499) All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables telemetry_service.test.ts. There is one test case left: calls expected URL with 20 minutes This test case is skipped due to function fetchTelemetry is disabled. We should enable this test when fetchTelemtry function is restored. Partially solved issue: opensearch-project#499 Signed-off-by: Anan Zhuang <[email protected]>
✅ DCO Check Passed 0b21562 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/plugins/telemetry/public/services/telemetry_service.test.ts
Outdated
Show resolved
Hide resolved
I think this error message is expected. But I will open an issue later and will do more investigation. |
@ananzh can you open the issue now so that we have it documented? |
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables telemetry_service.test.ts. There is one test case left: calls expected URL with 20 minutes This test case is skipped due to function fetchTelemetry is disabled. We should enable this test when fetchTelemtry function is restored. Partially solved issue: #499 Signed-off-by: Anan Zhuang <[email protected]>
All the unit tests related to unused telemetry are temporarily skipped after the fork. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables telemetry_service.test.ts. There is one test case left: calls expected URL with 20 minutes This test case is skipped due to function fetchTelemetry is disabled. We should enable this test when fetchTelemtry function is restored. Partially solved issue: #499 Signed-off-by: Anan Zhuang <[email protected]>
Description
All the unit tests related to unused telemetry are temporarily
skipped after the fork. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_service.test.ts
Signed-off-by: Anan Zhuang [email protected]
Issues Resolved
#499 (1 test case is skipped)
Test results
unit test for telemetry_service.test.ts
Overall test result:
Check List