-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Enable unit test suite: telemetry_sender.test.ts #500
Conversation
…roject#498) All the unit tests related to unused telemetry are temporarily skipped at forking. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables telemetry_sender.test.ts. Signed-off-by: Anan Zhuang <[email protected]>
❌ DCO Check Failed 7f2e731 |
✅ DCO Check Passed 4a0ad4a |
Remove all the original comment out lines. If needs restore the unit test, can revert this commit. Signed-off-by: Anan Zhuang <[email protected]>
✅ DCO Check Passed 506ffb7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* [Test] Enable unit test suite: telemetry_sender.test.ts (#498) All the unit tests related to unused telemetry are temporarily skipped at forking. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables telemetry_sender.test.ts. Signed-off-by: Anan Zhuang <[email protected]> * [Test] Enable unit test suite: telemetry_sender.test.ts Remove all the original comment out lines. If needs restore the unit test, can revert this commit. Signed-off-by: Anan Zhuang <[email protected]>
* [Test] Enable unit test suite: telemetry_sender.test.ts (#498) All the unit tests related to unused telemetry are temporarily skipped at forking. Unit tests of the disabled telemetry functions should also be modified correspondingly. To build a clean unit test, we decide to modify and enable all the working unit tests. This PR modifies and enables telemetry_sender.test.ts. Signed-off-by: Anan Zhuang <[email protected]> * [Test] Enable unit test suite: telemetry_sender.test.ts Remove all the original comment out lines. If needs restore the unit test, can revert this commit. Signed-off-by: Anan Zhuang <[email protected]>
The commit adds a first alpha version of the SmallMultiple chart configuration as requested in opensearch-project#500 Two main components are used to describe the small multiples: - `<GroupBy />` is a generic component that allows the specification of a group by operation and sorting order. The `by` prop request a function with two arguments, the spec and the datum. It's called for each spec and for each data point available in the data array of a spec. It should return a unique value used to group the data points into multiple series. - `<SmallMultiples />` component with two main optional props: `splitVertically` or `splitHorizontally` where you can specify the `id` of a `GroupBy` operator to render vertically (one below the other) or horizontally (one aside the other) the series defined by that group operation. A preliminary style configuration can be used to configure inner and outer padding in percentage for the vertical or horizontal charts. close opensearch-project#500 Co-authored-by: Nick Partridge <[email protected]>
# [24.1.0](elastic/elastic-charts@v24.0.0...v24.1.0) (2020-11-24) ### Bug Fixes * **area_charts:** correctly represent baseline with negative data points ([opensearch-project#896](elastic/elastic-charts#896)) ([b622fda](elastic/elastic-charts@b622fda)) * **legend:** legend sizes with ordinal data ([opensearch-project#867](elastic/elastic-charts#867)) ([74bcbad](elastic/elastic-charts@74bcbad)), closes [opensearch-project#811](elastic/elastic-charts#811) * render orphan data points on lines and areas ([opensearch-project#900](elastic/elastic-charts#900)) ([3e2c739](elastic/elastic-charts@3e2c739)), closes [opensearch-project#783](elastic/elastic-charts#783) * specs swaps correctly reflected in state ([opensearch-project#901](elastic/elastic-charts#901)) ([a94347f](elastic/elastic-charts@a94347f)) ### Features * **legend:** allow legend text to be copyable ([opensearch-project#877](elastic/elastic-charts#877)) ([21a96d3](elastic/elastic-charts@21a96d3)), closes [opensearch-project#710](elastic/elastic-charts#710) * allow clearing series colors from memory ([opensearch-project#899](elastic/elastic-charts#899)) ([e97f4ab](elastic/elastic-charts@e97f4ab)) * merge series domain with the domain of another group ([opensearch-project#912](elastic/elastic-charts#912)) ([716ad5a](elastic/elastic-charts@716ad5a)) * small multiples for XY charts (alpha) ([opensearch-project#793](elastic/elastic-charts#793)) ([3b88e1c](elastic/elastic-charts@3b88e1c)), closes [opensearch-project#500](elastic/elastic-charts#500) [opensearch-project#500](elastic/elastic-charts#500)
Description
All the unit tests related to unused telemetry are temporarily
skipped at forking. Unit tests of the disabled telemetry
functions should also be modified correspondingly. To build
a clean unit test, we decide to modify and enable all the
working unit tests. This PR modifies and enables
telemetry_sender.test.ts.
Signed-off-by: Anan Zhuang [email protected]
Issues Resolved
#498
Test results
unit test for telemetry_sender.test.ts
Overall test result:
Check List