-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (home): Add new theme dashboard screenshots #4906
Feat (home): Add new theme dashboard screenshots #4906
Conversation
- Add `next` theme variant screenshots of sample dashboards with `_new` suffix - Add chromed screenshots of flights dashboard to use as the images in the new theme modal and replace placeholders - Tweak gutter size in new theme modal - Add `hasNewThemeImages` optional boolean to sample dataset registry interface - Update sample data cards image path logic to fetch themed images if available via `hasNewThemeImages` prop Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4906 +/- ##
==========================================
- Coverage 66.39% 66.39% -0.01%
==========================================
Files 3397 3397
Lines 64805 64807 +2
Branches 10360 10361 +1
==========================================
- Hits 43028 43027 -1
- Misses 19217 19225 +8
+ Partials 2560 2555 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks!
Signed-off-by: Miki <[email protected]>
Josh thanks for this. I minified the updated images. |
Can you document the procedure for doing this? |
I usually use |
Looks so good! |
* Feat (home): Add new theme dashboard screenshots - Add `next` theme variant screenshots of sample dashboards with `_new` suffix - Add chromed screenshots of flights dashboard to use as the images in the new theme modal and replace placeholders - Tweak gutter size in new theme modal - Add `hasNewThemeImages` optional boolean to sample dataset registry interface - Update sample data cards image path logic to fetch themed images if available via `hasNewThemeImages` prop Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> * Minified new theme dashboard screenshots Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit f9d3c34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
* Feat (home): Add new theme dashboard screenshots - Add `next` theme variant screenshots of sample dashboards with `_new` suffix - Add chromed screenshots of flights dashboard to use as the images in the new theme modal and replace placeholders - Tweak gutter size in new theme modal - Add `hasNewThemeImages` optional boolean to sample dataset registry interface - Update sample data cards image path logic to fetch themed images if available via `hasNewThemeImages` prop Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> * Minified new theme dashboard screenshots Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit f9d3c34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
next
theme variant screenshots of sample dashboards with_new
suffixhasNewThemeImages
optional boolean to sample dataset registry interfacehasNewThemeImages
propThe approach to the sample dataset registry was a bit lazy; but I didn't want to introduce any more props than necessary, while also not breaking any other sample dataset registrations that won't have themed variants.
Issues Resolved
Fixes #4673
Completes TODOs from #4715
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr