[Follow-up] Fix extraction script

[curq]

Description

This is a follow-up fix to #4794, after the initial bug was solved in this pr. There were 2 additional errors that prevented script from running after I tried to running script later.

ERROR  I18N ERROR  Error in src/plugins/vis_type_vega/public/expressions/vega_fn.ts
      Error: There is more than one default message for the same id "visTypeVega.function.help":
      "Construct line vega spec" and "Vega visualization"

ERROR  I18N ERROR  Error in src/plugins/visualizations/public/embeddable/visualize_embeddable.ts
      Error: expressions are not allowed in template literals ("visualizations.renderVisTitle").

I tried running script again after some time and there were 3 more new errors

It looks like they were introduced in recent PRs related to discover.

Issues Resolved

#4794

Screenshot

Testing the changes

We can test it by running the script from #4794
./scripts/use_node scripts/i18n_extract.js --output-dir plugins/dashboards-i18n/translations/ It will create en.json file in output directory without any errors. If no such directory we can output result to root directory to check ./scripts/use_node scripts/i18n_extract.js --output-dir plugins/dashboards-i18n/translations/

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Merging #4895 (585d7eb) into main (83cd7f6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4895      +/-   ##
==========================================
- Coverage   66.39%   66.39%   -0.01%     
==========================================
  Files        3397     3397              
  Lines       64804    64804              
  Branches    10360    10360              
==========================================
- Hits        43028    43026       -2     
- Misses      19217    19218       +1     
- Partials     2559     2560       +1     

Flag	Coverage Δ
Linux_1	34.85% <ø> (ø)
Linux_2	55.15% <ø> (ø)
Linux_3	44.23% <ø> (ø)
Linux_4	34.92% <ø> (ø)
Windows_1	34.87% <ø> (ø)
Windows_2	55.12% <ø> (ø)
Windows_3	44.24% <ø> (-0.01%)	⬇️
Windows_4	34.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...izations/public/embeddable/visualize_embeddable.ts	19.65% <ø> (ø)

... and 1 file with indirect coverage changes

[ananzh]

nice. thank you!