[Manual Backport 2.x][@osd/pm] Automate multi-target bootstrap and build (#4650) #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#4650) Also: * build @osd/std for multiple targets * convert @osd/i18n and @osd/ace from custom build scripts to targeted build process * have @osd/optimizer ignore already built artifacts Signed-off-by: Miki <[email protected]> (cherry picked from commit 1674c97)
ashwin-pc
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4860 +/- ##
==========================================
- Coverage 66.32% 66.32% -0.01%
==========================================
Files 3321 3322 +1
Lines 63897 63911 +14
Branches 10112 10119 +7
==========================================
+ Hits 42382 42386 +4
- Misses 19028 19045 +17
+ Partials 2487 2480 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@ashwin-pc I think you'll need to update snapshots for this, as there are changes due to #4796 already being merged. |
AMoo-Miki
reviewed
Aug 30, 2023
Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]>
AMoo-Miki
approved these changes
Aug 31, 2023
|
Cypress tests will pass once the Data explorer changes are merged to 2.x |
ZilongX
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherrypick 1674c97 from #4650