Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Fix darkmode for histogram #4858

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

abbyhu2000
Copy link
Member

Description

Fix darkmode for histogram. Previously after switching to darkmode, histogram still have light mode color scheme.

Issues Resolved

Screenshot

Screen.Recording.2023-08-30.at.1.07.56.PM.mov

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 30, 2023
@ananzh
Copy link
Member

ananzh commented Aug 30, 2023

Screenshot 2023-08-30 at 13 21 27

Compared with legacy, seems the LineAnnotation is not fetching dark mode properly? But I think we should merge in this one and then create an issue to research on it.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4858 (3889b71) into main (03ae2bd) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4858      +/-   ##
==========================================
- Coverage   66.46%   66.44%   -0.03%     
==========================================
  Files        3390     3396       +6     
  Lines       64742    64865     +123     
  Branches    10312    10355      +43     
==========================================
+ Hits        43030    43097      +67     
- Misses      19169    19210      +41     
- Partials     2543     2558      +15     
Flag Coverage Δ
Linux_1 34.85% <ø> (-0.02%) ⬇️
Linux_2 55.15% <ø> (ø)
Linux_3 44.24% <ø> (+0.06%) ⬆️
Linux_4 35.04% <ø> (ø)
Windows_1 34.87% <ø> (-0.02%) ⬇️
Windows_2 55.12% <ø> (ø)
Windows_3 44.24% <ø> (+0.05%) ⬆️
Windows_4 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@joshuarrrr
Copy link
Member

joshuarrrr commented Aug 30, 2023

It looks like you were able to grab the changes necessary; the PR that fixed this for legacy discover is #4644

@joshuarrrr
Copy link
Member

@abbyhu2000 Did you test with the new next theme?

@ashwin-pc
Copy link
Member

@joshuarrrr how do you do that?

@ashwin-pc ashwin-pc merged commit 89013da into opensearch-project:main Aug 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4858-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89013dad0848567094243bb86de42acd127bc5da
# Push it to GitHub
git push --set-upstream origin backport/backport-4858-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4858-to-2.x.

@joshuarrrr
Copy link
Member

You can toggle it in Advanced Settings - just search for "theme"

ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 31, 2023
* fix darkmode for histogram

Signed-off-by: abbyhu2000 <[email protected]>

* changelog

Signed-off-by: abbyhu2000 <[email protected]>

* remove changelog

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 89013da)
@abbyhu2000
Copy link
Member Author

@abbyhu2000 Did you test with the new next theme?

No i have not, how do we enable the next theme? @joshuarrrr

@joshuarrrr
Copy link
Member

See #4858 (comment). Just choose Next (preview) from the theme selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants