-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Fix darkmode for histogram #4858
[Data Explorer] Fix darkmode for histogram #4858
Conversation
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4858 +/- ##
==========================================
- Coverage 66.46% 66.44% -0.03%
==========================================
Files 3390 3396 +6
Lines 64742 64865 +123
Branches 10312 10355 +43
==========================================
+ Hits 43030 43097 +67
- Misses 19169 19210 +41
- Partials 2543 2558 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
It looks like you were able to grab the changes necessary; the PR that fixed this for legacy discover is #4644 |
@abbyhu2000 Did you test with the new |
@joshuarrrr how do you do that? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4858-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89013dad0848567094243bb86de42acd127bc5da
# Push it to GitHub
git push --set-upstream origin backport/backport-4858-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
You can toggle it in Advanced Settings - just search for "theme" |
* fix darkmode for histogram Signed-off-by: abbyhu2000 <[email protected]> * changelog Signed-off-by: abbyhu2000 <[email protected]> * remove changelog Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 89013da)
No i have not, how do we enable the |
See #4858 (comment). Just choose Next (preview) from the theme selector. |
Description
Fix darkmode for histogram. Previously after switching to darkmode, histogram still have light mode color scheme.
Issues Resolved
Screenshot
Screen.Recording.2023-08-30.at.1.07.56.PM.mov
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr