[Data Explorer] Fix breadcrumb for data explorer #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
8 tasks
Signed-off-by: abbyhu2000 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4856 +/- ##
==========================================
- Coverage 66.46% 66.44% -0.03%
==========================================
Files 3390 3396 +6
Lines 64742 64865 +123
Branches 10312 10355 +43
==========================================
+ Hits 43030 43097 +67
- Misses 19169 19210 +41
- Partials 2543 2558 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
ashwin-pc
reviewed
Aug 30, 2023
CHANGELOG.md
Outdated
| @@ -226,6 +226,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Add support for Node.js >=14.20.1 <19 ([#4071](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4071)) | |||
| - Bundle Node.js 14 as a fallback for operating systems that cannot run Node.js 18 ([#4151](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4151)) | |||
| - Enhance grouping for context menus ([#3924](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3924)) | |||
| - [Data Explorer] Fix breadcrumb for data explorer ([#4856](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4856)) | |||
There was a problem hiding this comment.
Skip changelog for these changes since Data explorer is going out for the first time this release anyways
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
added
the
Skip-Changelog
ananzh
approved these changes
Aug 30, 2023
ashwin-pc
approved these changes
Aug 30, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4856-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7faa088c1a23cf4a47c8148919c5ea99d35d5a03
# Push it to GitHub
git push --set-upstream origin backport/backport-4856-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
ashwin-pc
pushed a commit
to ashwin-pc/OpenSearch-Dashboards
that referenced
this pull request
Aug 31, 2023
…4856) * add breadcrumb --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 7faa088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix breadcrumb for data explorer.
Issues Resolved
resolves #4779
Screenshot
Screen.Recording.2023-08-30.at.10.20.31.AM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr