Feat (Advanced Settings): Make new "Appearance" category

[joshuarrrr]

Description

And remove "Accessibility".
Give category panels IDs so they can be deep linked

Copy and other settings updates will follow in separate PRs.

Issues Resolved

Partial implementation of #4330
Unblocks #4676

Screenshot

Note that advanced settings are automatically ordered alphabetically by the setting name.

Screen.Recording.2023-08-28.at.3.20.10.PM.mov

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Merging #4845 (9957efa) into main (ce2d79e) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4845      +/-   ##
==========================================
- Coverage   66.39%   66.39%   -0.01%     
==========================================
  Files        3396     3397       +1     
  Lines       64801    64804       +3     
  Branches    10359    10360       +1     
==========================================
+ Hits        43025    43026       +1     
- Misses      19217    19218       +1     
- Partials     2559     2560       +1     

Flag	Coverage Δ
Linux_1	34.85% <ø> (ø)
Linux_2	55.15% <ø> (ø)
Linux_3	44.23% <ø> (-0.01%)	⬇️
Linux_4	34.92% <ø> (ø)
Windows_1	34.87% <ø> (ø)
Windows_2	55.12% <ø> (ø)
Windows_3	44.24% <ø> (+<0.01%)	⬆️
Windows_4	34.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
.../core/server/ui_settings/settings/accessibility.ts	100.00% <ø> (ø)
src/core/server/ui_settings/settings/navigation.ts	100.00% <ø> (ø)
src/core/server/ui_settings/settings/theme.ts	100.00% <ø> (ø)
...ngs/public/management_app/components/form/form.tsx	69.69% <ø> (ø)
...ngs/public/management_app/lib/get_category_name.ts	66.66% <ø> (ø)

... and 3 files with indirect coverage changes

[joshuarrrr]

@KrooshalUX This is ready for your review. Note that it's not everything from #4330, but it does have everything moved to the new section, which is deep linkable. Given this minimal implementation, should I go ahead and also update the copy to match the mock (except for the browser settings, which won't be supported in 2.10).

@mnkugler The issue mentions that we want the theme description text to link to a forum post. Can you provide that forum post URL?

[KrooshalUX]

👍 this is great incremental progress towards the north star of appearance within advanced settings (#4330 )!

[kavilla]

Not sure if this a current issue but will we move forward with the other plugins to add to this category?

[ashwin-pc]

@joshuarrrr Some of the unit tests are failing here, can you look at them?

[joshuarrrr]

Not sure if this a current issue but will we move forward with the other plugins to add to this category?

Are you asking whether plugins can add additional settings to this Appearance category? If so, the answer is yes, which is consistent with how the other categories work.

[joshuarrrr]

TODO: update href with specific forum post.

I thought I could use the linkService here, but it's a case where we can't really; these settings are defined in /core/server and the linkService is in /core/public.

[joshuarrrr]

href updated