Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter actions on data table vis cells #4837

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Fix filter actions on data table vis cells #4837

merged 5 commits into from
Sep 13, 2023

Conversation

evamillan
Copy link
Contributor

Description

This PR replaces the rows used in the Data Table visualization when building the cell's filter for/out buttons with the sorted ones.

Issues Resolved

Fixes #4836

Screenshot

osd-table-filters-fixed

Testing the changes

  • Create a data table visualization
  • Change the sorting order on one of the columns
  • Click on the filter for value button inside a cell
  • The filter should match the text on the clicked cell

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #4837 (58bde3e) into main (620624c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4837      +/-   ##
==========================================
- Coverage   66.50%   66.50%   -0.01%     
==========================================
  Files        3403     3403              
  Lines       65021    65023       +2     
  Branches    10401    10401              
==========================================
  Hits        43242    43242              
- Misses      19211    19212       +1     
- Partials     2568     2569       +1
Flag Coverage Δ
Linux_1 34.82% <100.00%> (+<0.01%) ⬆️
Linux_2 55.31% <ø> (ø)
Linux_3 44.60% <ø> (-0.01%) ⬇️
Linux_4 34.89% <ø> (ø)
Windows_1 34.83% <100.00%> (+<0.01%) ⬆️
Windows_2 55.27% <ø> (ø)
Windows_3 44.61% <ø> (ø)
Windows_4 34.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pe_table/public/components/table_vis_component.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

AMoo-Miki
AMoo-Miki previously approved these changes Sep 11, 2023
View reviewed changes
@evamillan
Add changelog entry
22843e4 
Signed-off-by: Eva Millán <[email protected]>
BSFishy
BSFishy previously approved these changes Sep 11, 2023
View reviewed changes
@ananzh ananzh merged commit a925581 into opensearch-project:main Sep 13, 2023
103 of 104 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 13, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Fix filter actions on data table vis cells (#4837)
4d8ddc7 
* Fix filter actions on data table vis cells
* Add changelog entry

---------

Signed-off-by: Eva Millán <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
(cherry picked from commit a925581)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh added a commit that referenced this pull request Sep 13, 2023
@opensearch-trigger-bot @AMoo-Miki
@joshuarrrr @ananzh
Fix filter actions on data table vis cells (#4837) (#5000)
902148e 
* Fix filter actions on data table vis cells
* Add changelog entry

---------

Signed-off-by: Eva Millán <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
(cherry picked from commit a925581)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@BSFishy BSFishy BSFishy approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x first-time-contributor tableVis table visualization v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Data table vis applies wrong filter when sorted
5 participants
@evamillan @AMoo-Miki @BSFishy @ananzh @joshuarrrr