-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer][Discover 2.0] Change to inspect icon and update hint msg #4827
[Data Explorer][Discover 2.0] Change to inspect icon and update hint msg #4827
Conversation
Issue Resolve opensearch-project#4826 Signed-off-by: ananzh <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4827 +/- ##
=========================================================
- Coverage 66.50% 66.37% -0.14%
=========================================================
Files 3289 3388 +99
Lines 62821 64707 +1886
Branches 9788 10302 +514
=========================================================
+ Hits 41782 42950 +1168
- Misses 18658 19295 +637
- Partials 2381 2462 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this going as is but I dont think the icon needs to toggle between the two states. We can follow up with that in a future PR unless you want to address it here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This icon does not need to toggle between inspect
and minimize
…msg (opensearch-project#4827) Issue Resolve opensearch-project#4826 Signed-off-by: ananzh <[email protected]> (cherry picked from commit bef76fe)
Description
before
after
Issues Resolved
#4826