Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove minimum constraint on OpenSearch hosts to allow empty host and refactor status API to not include OpenSearch status when host is empty #4802

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8e1ec99 from #4701.

Signed-off-by: Bandini Bhopi <[email protected]>
(cherry picked from commit 8e1ec99)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4802 (ab640f8) into 2.x (d8f156f) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##              2.x    #4802      +/-   ##
==========================================
- Coverage   66.12%   66.12%   -0.01%     
==========================================
  Files        3315     3315              
  Lines       63909    63913       +4     
  Branches    10126    10128       +2     
==========================================
+ Hits        42259    42260       +1     
+ Misses      19170    19168       -2     
- Partials     2480     2485       +5     
Flag Coverage Δ
Linux_1 34.77% <ø> (ø)
Linux_2 55.10% <83.33%> (+<0.01%) ⬆️
Linux_3 43.02% <0.00%> (-0.02%) ⬇️
Linux_4 35.08% <0.00%> (-0.01%) ⬇️
Windows_1 34.79% <ø> (ø)
Windows_2 55.07% <83.33%> (+<0.01%) ⬆️
Windows_3 43.02% <0.00%> (-0.01%) ⬇️
Windows_4 35.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/server/opensearch/opensearch_config.ts 93.58% <ø> (ø)
src/core/server/opensearch/status.ts 70.00% <0.00%> (-7.78%) ⬇️
...rc/core/server/opensearch/client/cluster_client.ts 84.21% <100.00%> (ø)
src/core/server/opensearch/opensearch_service.ts 84.61% <100.00%> (+1.28%) ⬆️

... and 3 files with indirect coverage changes

@zhongnansu zhongnansu self-assigned this Aug 24, 2023
@joshuarrrr joshuarrrr merged commit d6826b8 into 2.x Aug 28, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-4701-to-2.x branch August 28, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.10.0 valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants