[Backport 2.x] [Dashboard De-Angular] Add more unit tests for utils folder #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 324919d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
added
de-angular
opensearch-trigger-bot
bot
requested review from
seanneumann and
AMoo-Miki
as code owners
opensearch-trigger-bot
bot
requested review from
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4685 +/- ##
==========================================
+ Coverage 66.12% 66.16% +0.03%
==========================================
Files 3315 3315
Lines 63909 63909
Branches 10126 10126
==========================================
+ Hits 42259 42284 +25
+ Misses 19170 19148 -22
+ Partials 2480 2477 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@abbyhu2000 Can you check the failing test? Did we miss a backport these tests rely on? |
Yes this backport #4683 needs to be merged before this backport PR |
joshuarrrr
approved these changes
Aug 29, 2023
abbyhu2000
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 324919d from #4641.