Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily remove Tutorials from "Add Data" page #464

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Temporarily remove Tutorials from "Add Data" page #464

merged 3 commits into from
Jun 11, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jun 9, 2021 •
edited by tmarkley
Loading

Signed-off-by: Anan Zhuang [email protected]

Description

Currently we don't have instructions/code samples/docs that instruct users to use apps to add data or download agents from artifacts.opensearch.org. Therefore, we decide to temporarily remove tutorials from add data page.

There are 3 places cx can enter into add data page. 2 of them is on home page (upper left and Ingest your data section) and 1 on overview page. This PR remove the add data page and only keep try sample data. Now the home page, overview page and add data page look like below:

  1. Home page:

Screen Shot 2021-06-08 at 5 11 17 PM

2)Overview page:
Screen Shot 2021-06-08 at 5 09 53 PM

3)When click add data or Add sample data , all goes to add data page:
Screen Shot 2021-06-08 at 5 11 41 PM

Issues Resolved

#426

Tests

1)Unit
Screen Shot 2021-06-08 at 4 25 13 PM
2)Integration
Screen Shot 2021-06-08 at 4 42 11 PM
3)Functional
Screen Shot 2021-06-08 at 7 38 58 PM

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 7ada5b0

@ananzh ananzh marked this pull request as draft June 9, 2021 01:19
@ananzh ananzh changed the title Temporarily remove Tutorials from "Add Data" page [draft]Temporarily remove Tutorials from "Add Data" page Jun 9, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 2687e55

@ananzh ananzh changed the title [draft]Temporarily remove Tutorials from "Add Data" page Temporarily remove Tutorials from "Add Data" page Jun 9, 2021
@ananzh ananzh added the enhancement New feature or request label Jun 9, 2021
@ananzh ananzh linked an issue Jun 9, 2021 that may be closed by this pull request
Remove Tutorials from "Add Data" page #426
Closed
@ananzh ananzh marked this pull request as ready for review June 9, 2021 02:43
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed c086703

@ananzh ananzh added the v1.0.0 label Jun 9, 2021
kavilla
kavilla previously approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! But please respond to comments so we have some tracking purposes.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 6dae1ec

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 70bca94

@ananzh ananzh mentioned this pull request Jun 9, 2021
Closed
@kavilla kavilla self-requested a review June 10, 2021 00:03
kavilla
kavilla previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: commit c086703 is beyond 50 characters limit, While looking the github UI you can see it wrap into the commit description. Many tools suffer if the commit message is too long.

Just a nitpick though. Feel free to ignore.

Otherwise looks good thank you.

@ananzh
Copy link
Member Author

ananzh commented Jun 10, 2021

NIT: commit c086703 is beyond 50 characters limit, While looking the github UI you can see it wrap into the commit description. Many tools suffer if the commit message is too long.

Just a nitpick though. Feel free to ignore.

Otherwise looks good thank you.

I see. I will amend this commit msg.

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed a97c661

ananzh added 3 commits June 10, 2021 22:06
@ananzh
temporarily remove tutorial
452a7bf 
Signed-off-by: Anan Zhuang <[email protected]>
@ananzh
change text
b51e3a0 
Signed-off-by: Anan Zhuang <[email protected]>
@ananzh
clean out all tabs contents
329b56b 
Signed-off-by: Anan Zhuang <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 329b56b

@kavilla kavilla self-requested a review June 10, 2021 23:51
boktorbb
boktorbb approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ananzh ananzh merged commit e322c1f into opensearch-project:main Jun 11, 2021
kavilla pushed a commit that referenced this pull request Jun 21, 2021
@ananzh @kavilla
Temporarily remove Tutorials from "Add Data" page (#464)
0882794 
* temporarily remove tutorial

Signed-off-by: Anan Zhuang <[email protected]>

* change text

Signed-off-by: Anan Zhuang <[email protected]>

* clean out all tabs contents

Signed-off-by: Anan Zhuang <[email protected]>
kavilla pushed a commit that referenced this pull request Jun 21, 2021
@ananzh @kavilla
Temporarily remove Tutorials from "Add Data" page (#464)
f530b8d 
* temporarily remove tutorial

Signed-off-by: Anan Zhuang <[email protected]>

* change text

Signed-off-by: Anan Zhuang <[email protected]>

* clean out all tabs contents

Signed-off-by: Anan Zhuang <[email protected]>
@ananzh ananzh deleted the i-426 branch September 14, 2021 17:32
@tmarkley tmarkley mentioned this pull request Feb 25, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkley tmarkley tmarkley left review comments

@boktorbb boktorbb boktorbb approved these changes

@kavilla kavilla kavilla approved these changes

@mihirsoni mihirsoni Awaiting requested review from mihirsoni

Assignees
No one assigned
Labels
enhancement New feature or request v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Tutorials from "Add Data" page
5 participants
@ananzh @opensearch-ci-bot @tmarkley @kavilla @boktorbb