[Table Visualization] Fix width of multiple tables when rendered in column view #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sirazh Gabdullin <[email protected]>
curq
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Signed-off-by: Sirazh Gabdullin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #4638 +/- ##
=======================================
Coverage 66.49% 66.49%
=======================================
Files 3402 3402
Lines 65011 65011
Branches 10401 10401
=======================================
Hits 43230 43230
Misses 19212 19212
Partials 2569 2569
Flags with carried forward coverage won't be shown. Click here to find out more.
|
manasvinibs
reviewed
Jul 28, 2023
| @@ -23,7 +23,7 @@ export const TableVisComponentGroup = memo( | |||
| return ( | |||
| <> | |||
| {tableGroups.map(({ table, title }) => ( | |||
| <EuiFlexItem key={title} className="visTable__group"> | |||
| <EuiFlexItem key={title} className="visTable__group" grow={false}> | |||
There was a problem hiding this comment.
Do we want to use flexGrow instead of grow here?
There was a problem hiding this comment.
I believe we should use grow, as it is the prop of OuiFlexItem that sets the flex-grow css property of div element within to specific value.
ananzh
previously approved these changes
Aug 21, 2023
Signed-off-by: Sirazh Gabdullin <[email protected]>
ananzh
approved these changes
Sep 12, 2023
manasvinibs
approved these changes
Sep 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
…olumn view (#4638) * fix table vis bug Signed-off-by: Sirazh Gabdullin <[email protected]> * update CHANGELOG Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> (cherry picked from commit 17683e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
added a commit
that referenced
this pull request
Sep 13, 2023
…olumn view (#4638) (#4999) * fix table vis bug * update CHANGELOG --------- Signed-off-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> (cherry picked from commit 17683e1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the visual bug where tables are rendered incorrectly as described in #4626
The cause of the issue was that this style
OpenSearch-Dashboards/src/plugins/vis_type_table/public/components/table_vis_app.scss
Lines 9 to 12 in 6bab7ef
Was not overriding the styles of
OuiFlexItem, so theflex-growremained default as 1, instead of 0. The fix sets the grow property to 0 throughgrowprop.Issues Resolved
#4626
Screenshot
Here how the tables look after the fix.
Testing the changes
Go to tables visualizations, split rows then split tables. Choose the column view. Check if the visual bug is fixed.
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr