[BUG] Fix management overview page duplicate rendering #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Hailong-am
changed the title
Hailong-am
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4636 +/- ##
==========================================
- Coverage 66.43% 66.43% -0.01%
==========================================
Files 3396 3397 +1
Lines 64869 64882 +13
Branches 10358 10359 +1
==========================================
+ Hits 43096 43102 +6
- Misses 19214 19300 +86
+ Partials 2559 2480 -79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hailong-am
force-pushed
the
optimize_management_overview
branch
2 times, most recently
from
ebd9a24 to
fd252cd
Compare
|
@ashwin-pc @manasvinibs @ananzh could you help to review the fix? |
ashwin-pc
previously approved these changes
Aug 4, 2023
Hailong-am
force-pushed
the
optimize_management_overview
branch
from
fd252cd to
b3d7c13
Compare
rebased from main. |
Hailong-am
force-pushed
the
optimize_management_overview
branch
from
b3d7c13 to
892474e
Compare
|
Link check failed due to, not sure whether it's transient issue |
|
@ashwin-pc conflicts merged and please help to add backport 2.x label. |
Hailong-am
force-pushed
the
optimize_management_overview
branch
from
892474e to
5004ee0
Compare
ashwin-pc
reviewed
Aug 24, 2023
src/plugins/management_overview/public/__snapshots__/application.test.tsx.snap
Outdated
Show resolved
Hide resolved
Hailong-am
force-pushed
the
optimize_management_overview
branch
from
30444a0 to
c506258
Compare
joshuarrrr
reviewed
Aug 30, 2023
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]>
Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
optimize_management_overview
branch
from
4b9f56c to
bad97e2
Compare
AMoo-Miki
approved these changes
Aug 31, 2023
ashwin-pc
approved these changes
Aug 31, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
* refactor for management overview page Signed-off-by: Hailong Cui <[email protected]> * Add missing changelog Signed-off-by: Hailong Cui <[email protected]> * Add unit test Signed-off-by: Hailong Cui <[email protected]> * remove duplicate snapshot validation Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/management_overview/public/application.test.tsx Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/management_overview/public/application.test.tsx Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * export empty plugin start to make it consistent Signed-off-by: Hailong Cui <[email protected]> * export empty plugin start to make it consistent Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 16b1e29) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
manasvinibs
pushed a commit
that referenced
this pull request
Sep 1, 2023
* refactor for management overview page Signed-off-by: Hailong Cui <[email protected]> * Add missing changelog Signed-off-by: Hailong Cui <[email protected]> * Add unit test Signed-off-by: Hailong Cui <[email protected]> * remove duplicate snapshot validation Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/management_overview/public/application.test.tsx Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * Update src/plugins/management_overview/public/application.test.tsx Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Hailong Cui <[email protected]> * export empty plugin start to make it consistent Signed-off-by: Hailong Cui <[email protected]> * export empty plugin start to make it consistent Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 16b1e29) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor management overview page add
useMemoto avoid duplicate rendering.Issues Resolved
#4287 Add a new management overview page, whenever go to
app/opensearch_management_overviewpage, the console reports below errors.Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr