Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual][Backport 2.x]Update main menu to display 'Dashboards' for consistency (#4453) #4506

Conversation

manasvinibs
Copy link
Member


Signed-off-by: Danila Gulderov [email protected]
(cherry picked from commit bbf8dfb)

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…project#4453)

* Update main menu to display 'Dashboards' for consistency. Fixes opensearch-project#4296
This resolves the inconsistency highlighted in issue opensearch-project#4296 (opensearch-project#4296). The decision to make this change was made in issue opensearch-project#68 (opensearch-project/ux#68)."
* Update OpenSearch Dashboard to OpenSearch Dashboards for consistence
* CHANGELOG.md update

---------

Signed-off-by: Danila Gulderov <[email protected]>
(cherry picked from commit bbf8dfb)
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #4506 (78df84c) into 2.x (0331696) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #4506      +/-   ##
==========================================
- Coverage   66.40%   66.40%   -0.01%     
==========================================
  Files        3245     3245              
  Lines       62449    62449              
  Branches     9711     9711              
==========================================
- Hits        41472    41471       -1     
- Misses      18621    18623       +2     
+ Partials     2356     2355       -1     
Flag Coverage Δ
Linux 66.35% <ø> (+<0.01%) ⬆️
Windows 66.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/dashboard/public/plugin.tsx 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

@manasvinibs manasvinibs merged commit 6bff689 into opensearch-project:2.x Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants