[Dashboard De-Angular] Add dashboard class for discard flow #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
abbyhu2000
force-pushed
the
feature/deangular-dashboards
branch
from
22cfbb8 to
c3037a0
Compare
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
force-pushed
the
deangular/add-dashboard-class
branch
from
e9aba8f to
a8b2495
Compare
kavilla
approved these changes
Jul 1, 2023
abbyhu2000
added a commit
that referenced
this pull request
Jul 5, 2023
* Add Dashboard class for state managing Signed-off-by: abbyhu2000 <[email protected]> * isDirty working for cancel flow Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
added a commit
that referenced
this pull request
Jul 6, 2023
* Add Dashboard class for state managing Signed-off-by: abbyhu2000 <[email protected]> * isDirty working for cancel flow Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this pull request
Jul 7, 2023
…ch-project#4478) * Add Dashboard class for state managing Signed-off-by: abbyhu2000 <[email protected]> * isDirty working for cancel flow Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
added a commit
that referenced
this pull request
Jul 7, 2023
* Add Dashboard class for state managing Signed-off-by: abbyhu2000 <[email protected]> * isDirty working for cancel flow Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make discard flow working on dashboard:
-- Add a Dashboard class to store the original state values, so they can be retrieved if
discard-- Add a
isDirtyflag in the app state to indicate if there are unsaved changesIssues Resolved
#4433
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr